Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for override the default endpoint URL and insecure option #2962

Closed
eranco74 opened this issue Jan 30, 2019 · 11 comments · Fixed by GoogleCloudPlatform/magic-modules#1880
Assignees

Comments

@eranco74
Copy link

eranco74 commented Jan 30, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Allow to configure terraform to work with custom endpoint rather than www.googleapis.com/compute www.googleapis.com/storage and others.
Also, in case of selfsigned certificate on that endpoint, it would be great to provide an insecure option.

New or Affected Resource(s)

  • None

Potential Terraform Configuration

Allow overriding the default endpoint URL. this option should allow connection to custom GCE endpoints
The insecure option should allow the provider to perform "insecure" SSL requests. If omitted, default value should be false.
# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

  • #0000
@ghost ghost added the enhancement label Jan 30, 2019
@Chupaka
Copy link
Contributor

Chupaka commented Jan 30, 2019

How much "insecure"?.. Any background for the request?

@rileykarson rileykarson self-assigned this Jan 30, 2019
@rileykarson
Copy link
Collaborator

Hey @eran-stratoscale! As @Chupaka asked, it isn't clear which requests should be insecure or why based on this issue. Do you mind elaborating more, and sharing what kind of use case this opens up for you?

@eranco74 eranco74 changed the title Add support for insecure option Add support for override the default endpoint URL and insecure option Jan 30, 2019
@eranco74
Copy link
Author

Hey, I've updated the title and the description.

@rileykarson
Copy link
Collaborator

Thanks! If this is for https://www.terraform.io/docs/providers/google/r/endpoints_service.html, can you point out somewhere else the default endpoint URL / insecure option can be configured? For example, on the Cloud Console, gcloud, or through an API / language-specific client.

@eranco74
Copy link
Author

eranco74 commented Feb 3, 2019

Hey @rileykarson
This request is relevant for running terraform using the google provider on cloud providers that support the google cloud platform API.

In gcloud I can configure api endpoint overrides:
gcloud config set api_endpoint_overrides/compute http://localhost:8082/

This option is also supported in terraform aws provider:
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/config.go#L159

In the aws provider there is also an option to configure the insecure flag:
https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/config.go#L179

@ghost ghost removed the waiting-response label Feb 3, 2019
@romfreiman
Copy link

@Chupaka @rileykarson does the requirement make sense? The goal is to configure terraform to work with custom endpoint rather than google.com/ auth2.google.com and others.
Also, in case of selfsigned certificate on that endpoint, it would be great to provide an insecure mode.

Similar to what aws provider supports

@rileykarson
Copy link
Collaborator

rileykarson commented Feb 11, 2019

The requirement makes sense, I'll follow through on what changes this would require. I'll probably post an update ~EOW.

@rileykarson
Copy link
Collaborator

Alright, went through the changes with the team and confirmed this is something we want to do. That said, it's also something we'd like to cut over almost entirely in a single release, and there's some work to be done in Magic Modules to support this use case. None of us have cycles immediately, but this is absolutely an issue we're going to tackle for a future release.

If I don't find time within the next ~month I'll set aside time to work through this change.

@romfreiman
Copy link

romfreiman commented Feb 17, 2019

@rileykarson can we @ Stratoscale assist maybe?

@rileykarson
Copy link
Collaborator

I'd rather do most of this in one swoop I think, it's just a matter of me getting enough time to accomplish that in a short enough time period to include it in a release window.

@ghost
Copy link

ghost commented Jul 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants