Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint rule against fixed GCP URLs appearing in code #21266

Open
rileykarson opened this issue Feb 5, 2025 · 0 comments
Open

Add lint rule against fixed GCP URLs appearing in code #21266

rileykarson opened this issue Feb 5, 2025 · 0 comments

Comments

@rileykarson
Copy link
Collaborator

rileykarson commented Feb 5, 2025

What kind of contribution is this issue about?

Other (specify in details)

Details

Fixed GCP URLs like ""https://servicedirectory.googleapis.com/v1/"" are unsafe to use as universe domain and custom endpoint substitution will no longer function correctly. We need to check BasePaths like ServiceDirectoryBasePath. Misses were par for the course when custom endpoints were a mostly hacky solution but we want to preempt these kind of issues more for custom universes now.

We should lint against new fixed GCP URLs appearing outside of "safe" locations like the definition of GCP default URLs for a service.

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants