Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for SecretManager Filtering Data Source #14556

Closed

Comments

@lmayorga1980
Copy link

It would be nice to support this.

https://cloud.google.com/secret-manager/docs/filtering

@ScottSuarez
Copy link
Collaborator

Could you list some potential usecases? I'm sure you have them in mind. Maybe with example terraform configs?

@rileykarson
Copy link
Collaborator

@ScottSuarez why is this labeled service/terraform?

@ScottSuarez
Copy link
Collaborator

mm I see ** There is sufficient detail for the ticket to be workable **. This is a violation of this clause correct?

@lmayorga1980
Copy link
Author

@ScottSuarez I think this fits into the google provider since it implements the functionality for querying this specialized type of data from gcp.

@ScottSuarez
Copy link
Collaborator

Could you list some potential usecases? I'm sure you have them in mind. Maybe with example terraform configs?

@lmayorga1980
Copy link
Author

For instance if I want to find a secret that matches a naming convention or with a specific label

data "google_secret_manager_secret" "qa" {
  # Filtering is already supported by the API 
  filter ={
     label = "/${var.region}/${var.othervar}/*value"  
  }
 
}

@ScottSuarez
Copy link
Collaborator

Do you see this as being consumed by other resources or being set as an output field? What inter-resource connections do you see this as useful?

Copy link

github-actions bot commented Nov 9, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.