Media CDN EdgeCacheService and EdgeCacheOrigin resources enforce limits smaller than the Google API

[justin-mp]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform 0.13.7
Google Provider: v4.57.0

Affected Resource(s)

• google_resource_network_services_edge_cache_origin.go
• google_resource_network_services_edge_cache_service.go

Terraform Configuration Files

In google_resource_network_services_edge_cache_service.go, the provider has the following MaxItems limits:

"expose_headers": {
	Type:        schema.TypeList,
	Optional:    true,
	MaxItems:    5,
},
"allow_headers": {
	Type:        schema.TypeList,
	Optional:    true,
	MaxItems:    5,
},
"request_header_to_remove": {
	Type:        schema.TypeList,
	Optional:    true,
	MinItems:    1,
	MaxItems:    10,
},
"response_header_to_add": {
	Type:     schema.TypeList,
	Optional: true,
	MinItems: 1,
	MaxItems: 5,
},
"response_header_to_remove": {
	Type:        schema.TypeList,
	Optional:    true,
	MinItems:    1,
	MaxItems:    10,
},

In google_resource_network_services_edge_cache_origin.go, the provider has the following MaxItems limits:

"request_headers_to_add": {
	Type:     schema.TypeList,
	Optional: true,
	MinItems: 1,
	MaxItems: 5,
},

Debug Output

N/A

Panic Output

N/A

Expected Behavior

Google Media CDN has higher limits for these items and Terraform should not artificially restrict the limits.

• According to https://cloud.google.com/media-cdn/docs/reference/rest/v1/projects.locations.edgeCacheOrigins#originheaderaction , customers may set up to 25 requestHeadersToAdd in an EdgeCacheOrigin.
• According to https://cloud.google.com/media-cdn/docs/reference/rest/v1/projects.locations.edgeCacheServices#headeraction, customers may set:
  • 25 requestHeadersToAdd
  • 25 responseHeadersToAdd
  • 25 requestHeadersToRemove
  • 25 responseHeadersToRemove
• According to https://cloud.google.com/media-cdn/docs/reference/rest/v1/projects.locations.edgeCacheServices#corspolicy, customers may set:
  • 25 allowHeaders
  • 25 exposeHeaders

Terraform should have the same limits (or no limits).

Actual Behavior

Terraform limits the MaxItems allowed.

Steps to Reproduce

Add more than the allowed number of items and then run terraform apply.

Important Factoids

References

• #0000

[edwardmedia]

It appears the api has updated its spec on these fields

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.