Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing display name on google_bigquery_data_transfer_config resource shouldn't force replacement #12012

Closed
amardeep opened this issue Jul 4, 2022 · 4 comments
Assignees
Labels
bug forward/review In review; remove label to forward service/bigquery

Comments

@amardeep
Copy link

amardeep commented Jul 4, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.2.4
on darwin_arm64
+ provider registry.terraform.io/hashicorp/google v4.27.0

Affected Resource(s)

  • google_bigquery_data_transfer_config

with data_source_id = "google_cloud_storage"

Terraform Configuration Files

terraform {
  required_providers {
    # https://registry.terraform.io/providers/hashicorp/google/latest/docs
    google = {
      source  = "hashicorp/google"
      version = "~> 4.27.0"
    }
  }
}

provider "google" {
  project = "..."
  region  = "us-central1"
  zone    = "us-central1-c"
}

resource "google_bigquery_data_transfer_config" "test" {
  display_name   = "Test name"
  data_source_id = "google_cloud_storage"
  location       = "US"

  schedule               = "every day 08:09"
  destination_dataset_id = "..."

  params = {
    allow_jagged_rows               = "true"
    allow_quoted_newlines           = "true"
    data_path_template              = "..."
    destination_table_name_template = "test"
    field_delimiter                 = ","
    file_format                     = "CSV"
    max_bad_records                 = "0"
    skip_leading_rows               = "1"
    write_disposition               = "MIRROR"
  }

  email_preferences {
    enable_failure_email = true
  }
}

Expected Behavior

terraform plan shouldn't show force replacement needed

Actual Behavior

terraform plan shows force replacement needed

# google_bigquery_data_transfer_config.test must be replaced
-/+ resource "google_bigquery_data_transfer_config" "test" {
...
~ display_name  = "Old test name" -> "Test name" # forces replacement
...
}

Plan: 1 to add, 0 to change, 1 to destroy.
@amardeep amardeep added the bug label Jul 4, 2022
@edwardmedia edwardmedia self-assigned this Jul 4, 2022
@edwardmedia
Copy link
Contributor

@amardeep same answer to your question #12013

@edwardmedia
Copy link
Contributor

closing as a dup #12013

@amardeep
Copy link
Author

amardeep commented Jul 5, 2022

This is not a duplicate and i don't think it should be closed.

This is about display_name which is not part of params. And here the
behaviour is reverse. It shouldn't trigger force recreate, but it does.

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
@github-actions github-actions bot added service/bigquery forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug forward/review In review; remove label to forward service/bigquery
Projects
None yet
Development

No branches or pull requests

2 participants