Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management - update capacity to allow increasing the apim scalability to 31 #28427

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

dasaditya07
Copy link
Contributor

@dasaditya07 dasaditya07 commented Jan 7, 2025

… 31 which is provided by Microsoft

Microsoft now allows to sacle up the APIM instance to 31 per region but it is limited by terraform. So with the update in validation it can be updated to 31 using terraform. MS Docs: https://github.com/MicrosoftDocs/azure-docs/blob/main/includes/api-management-service-limits.md

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

… 31 which is provided by Microsoft

Microsoft now allows to sacle up the APIM instance to 31 per region but it is limited by terraform. So with the update in validation it can be updated to 31 using terraform.
MS Docs: https://github.com/MicrosoftDocs/azure-docs/blob/main/includes/api-management-service-limits.md
@dasaditya07
Copy link
Contributor Author

I didn't find any test involving my change but not sure for sure. Pelase validate once.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dasaditya07 LGTM ⛈️

@katbyte katbyte changed the title Update api_management_resource.go to increase the apim scalability to… Update api_management_resource.go to increase the apim scalability to 31 which is provided by Microsoft Jan 7, 2025
@katbyte katbyte changed the title Update api_management_resource.go to increase the apim scalability to 31 which is provided by Microsoft azurerm_api_management - update capacity to allow increasing the apim scalability to 31 Jan 7, 2025
@katbyte katbyte merged commit 91dd84f into hashicorp:main Jan 7, 2025
37 checks passed
@github-actions github-actions bot added this to the v4.15.0 milestone Jan 7, 2025
katbyte added a commit that referenced this pull request Jan 7, 2025
jackofallops pushed a commit that referenced this pull request Jan 10, 2025
jackofallops added a commit that referenced this pull request Jan 10, 2025
* Update CHANGELOG.md for #28233

* Update for #28215

* Update CHANGELOG.md for #28279

* Update CHANGELOG.md #28269

* Update CHANGELOG.md #27876

* Update CHANGELOG.md #28069

* Update CHANGELOG.md for #28312

* Update CHANGELOG.md for #28278

* Update CHANGELOG.md #28311

* Update CHANGELOG.md undo 28311

* Update CHANGELOG.md #27874

* Update CHANGELOG.md

* Update CHANGELOG for #28352

* Update CHANGELOG.md for #28390

* Update CHANGELOG.md for #28398

* Update CHANGELOG.md for #28425

* Update CHANGELOG.md #28427

* Update CHANGELOG.md #28280

* Update CHANGELOG.md for #28319

* Update CHANGELOG.md #24801

* Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442

* Update for #28379

* Update CHANGELOG.md for #28281

* Update for #28380

* Update for #27375

* Update for #25695

* Update CHANGELOG.md #27985

* Update CHANGELOG.md - update release date manually until can be scripted

* Update CHANGELOG.md revert date change as script available

* pre-release script updates

---------

Co-authored-by: stephybun <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: kt <[email protected]>
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
… scalability to 31 (hashicorp#28427)

Microsoft now allows to sacle up the APIM instance to 31 per region but it is limited by terraform. So with the update in validation it can be updated to 31 using terraform.
MS Docs: https://github.com/MicrosoftDocs/azure-docs/blob/main/includes/api-management-service-limits.md
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
* Update CHANGELOG.md for hashicorp#28233

* Update for hashicorp#28215

* Update CHANGELOG.md for hashicorp#28279

* Update CHANGELOG.md hashicorp#28269

* Update CHANGELOG.md hashicorp#27876

* Update CHANGELOG.md hashicorp#28069

* Update CHANGELOG.md for hashicorp#28312

* Update CHANGELOG.md for hashicorp#28278

* Update CHANGELOG.md hashicorp#28311

* Update CHANGELOG.md undo 28311

* Update CHANGELOG.md hashicorp#27874

* Update CHANGELOG.md

* Update CHANGELOG for hashicorp#28352

* Update CHANGELOG.md for hashicorp#28390

* Update CHANGELOG.md for hashicorp#28398

* Update CHANGELOG.md for hashicorp#28425

* Update CHANGELOG.md hashicorp#28427

* Update CHANGELOG.md hashicorp#28280

* Update CHANGELOG.md for hashicorp#28319

* Update CHANGELOG.md hashicorp#24801

* Update for hashicorp#28360 hashicorp#28216 hashicorp#27830 hashicorp#28404 hashicorp#27401 hashicorp#27122 hashicorp#27931 hashicorp#28442

* Update for hashicorp#28379

* Update CHANGELOG.md for hashicorp#28281

* Update for hashicorp#28380

* Update for hashicorp#27375

* Update for hashicorp#25695

* Update CHANGELOG.md hashicorp#27985

* Update CHANGELOG.md - update release date manually until can be scripted

* Update CHANGELOG.md revert date change as script available

* pre-release script updates

---------

Co-authored-by: stephybun <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: Wyatt Fry <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: kt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants