Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix ] azurerm_redis_cache - Support for unsetting data_persistence_authentication_method #27932

Merged
merged 2 commits into from
Jan 14, 2025
Merged

[Bug Fix ] azurerm_redis_cache - Support for unsetting data_persistence_authentication_method #27932

merged 2 commits into from
Jan 14, 2025

Conversation

xuzhang3
Copy link
Contributor

@xuzhang3 xuzhang3 commented Nov 7, 2024

Support unset data_persistence_authentication_method

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27878

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@xuzhang3
Copy link
Contributor Author

xuzhang3 commented Nov 7, 2024

Failed tests is not relates with this PR.
image

@xuzhang3 xuzhang3 marked this pull request as ready for review November 7, 2024 06:01
@xuzhang3 xuzhang3 requested review from katbyte and a team as code owners November 7, 2024 06:01
@rcskosir rcskosir mentioned this pull request Nov 8, 2024
Closed
1 task
@rcskosir rcskosir added the bug label Nov 8, 2024
catriona-m
catriona-m requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xuzhang3 - I left one minor comment on this but can take another look once it is addressed. Thanks!

internal/services/redis/redis_cache_resource.go Outdated Show resolved Hide resolved
catriona-m
catriona-m approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuzhang3 LGTM!

@catriona-m catriona-m merged commit dca16af into hashicorp:main Jan 14, 2025
31 checks passed
@github-actions github-actions bot added this to the v4.16.0 milestone Jan 14, 2025
catriona-m added a commit that referenced this pull request Jan 14, 2025
@catriona-m
Update CHANGELOG.md #27932
fc9c529
jackofallops added a commit that referenced this pull request Jan 16, 2025
@stephybun @jackofallops
@catriona-m @sreallymatt @mbfrahry
CHANGELOG.md release v4.16.0 (#28488)
f54480d 
* update for #27680

* Update CHANGELOG.md for #28465

* Update CHANGELOG.md #27932

* Update CHANGELOG.md for #28505

* Update CHANGELOG.md for #28474

* Update CHANGELOG.md #28516

* Update CHANGELOG for #28456

* Update CHANGELOG.md for #28472

* Update CHANGELOG.md #28307

* Update CHANGELOG.md for #27859

* Update for #28519

* Update for #27791 #27528

* Update CHANGELOG.md for #28527

* update changelog links and generate provider schema

---------

Co-authored-by: jackofallops <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
@xuzhang3 @NotTheEvilOne
[Bug Fix ] azurerm_redis_cache - Support for unsetting `data_persis…
746b30c 
…tence_authentication_method` (hashicorp#27932)

* support for unsetting  data_persistence_authentication_method

* optimize data_persistence_authentication_method settings
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
@stephybun @jackofallops
@catriona-m @sreallymatt @mbfrahry @NotTheEvilOne
CHANGELOG.md release v4.16.0 (hashicorp#28488)
9a8d11b 
* update for hashicorp#27680

* Update CHANGELOG.md for hashicorp#28465

* Update CHANGELOG.md hashicorp#27932

* Update CHANGELOG.md for hashicorp#28505

* Update CHANGELOG.md for hashicorp#28474

* Update CHANGELOG.md hashicorp#28516

* Update CHANGELOG for hashicorp#28456

* Update CHANGELOG.md for hashicorp#28472

* Update CHANGELOG.md hashicorp#28307

* Update CHANGELOG.md for hashicorp#27859

* Update for hashicorp#28519

* Update for hashicorp#27791 hashicorp#27528

* Update CHANGELOG.md for hashicorp#28527

* update changelog links and generate provider schema

---------

Co-authored-by: jackofallops <[email protected]>
Co-authored-by: catriona-m <[email protected]>
Co-authored-by: sreallymatt <[email protected]>
Co-authored-by: Matthew Frahry <[email protected]>
Co-authored-by: jackofallops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catriona-m catriona-m catriona-m approved these changes

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
bug service/redis size/M
Projects
None yet
Milestone
v4.16.0
Development

Successfully merging this pull request may close these issues.

azurerm_redis_cache: provider says that it will update data_persistence_authentication_method but does not
3 participants
@xuzhang3 @catriona-m @rcskosir