-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource] azurerm_machine_learning_workspace_network_outbound_rule_private_endpoint
#27874
[New Resource] azurerm_machine_learning_workspace_network_outbound_rule_private_endpoint
#27874
Conversation
CI error is not relate with this PR. All tests passed |
azurerm_machine_learning_workspace_network_outbound_rule_private_endpoint
azurerm_machine_learning_workspace_network_outbound_rule_private_endpoint
…into f/mlw_vnetrule_privateendpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xuzhang3, I had a look through this and left some comments inline, once those are addressed I can take another look. Thanks!
...achinelearning/machine_learning_workspace_network_outbound_rule_private_endpoint_resource.go
Show resolved
Hide resolved
|
||
resId, err := resourceids.ParseAzureResourceID(model.ServiceResourceId) | ||
if err != nil { | ||
return fmt.Errorf(" parsing resource ID: %+v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return fmt.Errorf(" parsing resource ID: %+v", err) | |
return err |
return err | ||
} | ||
|
||
future, err := client.SettingsRuleDelete(ctx, *id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we use SettingsRuleDeleteThenPoll
here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been updated to SettingsRuleDeleteThenPoll
|
||
future, err := client.SettingsRuleDelete(ctx, *id) | ||
if err != nil { | ||
return fmt.Errorf("deleting Machine Learning Workspace Private Endpoint Network Outbound Rule %q (Resource Group %q, Workspace %q): %+v", id.OutboundRuleName, id.ResourceGroupName, id.WorkspaceName, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return fmt.Errorf("deleting Machine Learning Workspace Private Endpoint Network Outbound Rule %q (Resource Group %q, Workspace %q): %+v", id.OutboundRuleName, id.ResourceGroupName, id.WorkspaceName, err) | |
return fmt.Errorf("deleting %s: %+v", id, err) |
if response.WasNotFound(resp.HttpResponse) { | ||
return pointer.To(false), nil | ||
} | ||
return nil, fmt.Errorf("retrieving Machine Learning Workspace Outbound Rule Private Endpoint %q: %+v", state.ID, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return nil, fmt.Errorf("retrieving Machine Learning Workspace Outbound Rule Private Endpoint %q: %+v", state.ID, err) | |
return nil, fmt.Errorf("retrieving %s: %+v", state.ID, err) |
specify [timeouts](https://www.terraform.io/language/resources/syntax#operation-timeouts) for certain actions: | ||
|
||
* `create` - (Defaults to 30 minutes) Used when creating the Machine Learning Workspace Network Outbound Rule Private Endpoint. | ||
* `update` - (Defaults to 30 minutes) Used when updating the Machine Learning Workspace Network Outbound Rule Private Endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this resource doesn't appear to have an update func?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this resource cannot be updated. I follow the behavior in the portal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we remove the update
timeout here?
Thank for reviewing. updated as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this @xuzhang3 - I left a couple more comments inline but once those are addressed I can take another look. Thanks!
if prop.Destination.SparkEnabled != nil { | ||
state.SparkEnabled = *prop.Destination.SparkEnabled | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if prop.Destination.SparkEnabled != nil { | |
state.SparkEnabled = *prop.Destination.SparkEnabled | |
} | |
state.SparkEnabled = pointer.From(prop.Destination.SparkEnabled) |
if prop.Destination.SubresourceTarget != nil { | ||
state.SubresourceTarget = *prop.Destination.SubresourceTarget | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if prop.Destination.SubresourceTarget != nil { | |
state.SubresourceTarget = *prop.Destination.SubresourceTarget | |
} | |
state.SubresourceTarget = pointer.From(prop.Destination.SubresourceTarget) |
if prop.Destination.ServiceResourceId != nil { | ||
state.ServiceResourceId = *prop.Destination.ServiceResourceId | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if prop.Destination.ServiceResourceId != nil { | |
state.ServiceResourceId = *prop.Destination.ServiceResourceId | |
} | |
state.ServiceResourceId = pointer.From(prop.Destination.ServiceResourceId) |
...achinelearning/machine_learning_workspace_network_outbound_rule_private_endpoint_resource.go
Show resolved
Hide resolved
...achinelearning/machine_learning_workspace_network_outbound_rule_private_endpoint_resource.go
Show resolved
Hide resolved
specify [timeouts](https://www.terraform.io/language/resources/syntax#operation-timeouts) for certain actions: | ||
|
||
* `create` - (Defaults to 30 minutes) Used when creating the Machine Learning Workspace Network Outbound Rule Private Endpoint. | ||
* `update` - (Defaults to 30 minutes) Used when updating the Machine Learning Workspace Network Outbound Rule Private Endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we remove the update
timeout here?
All updated per suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xuzhang3 LGTM!
* Update CHANGELOG.md for #28233 * Update for #28215 * Update CHANGELOG.md for #28279 * Update CHANGELOG.md #28269 * Update CHANGELOG.md #27876 * Update CHANGELOG.md #28069 * Update CHANGELOG.md for #28312 * Update CHANGELOG.md for #28278 * Update CHANGELOG.md #28311 * Update CHANGELOG.md undo 28311 * Update CHANGELOG.md #27874 * Update CHANGELOG.md * Update CHANGELOG for #28352 * Update CHANGELOG.md for #28390 * Update CHANGELOG.md for #28398 * Update CHANGELOG.md for #28425 * Update CHANGELOG.md #28427 * Update CHANGELOG.md #28280 * Update CHANGELOG.md for #28319 * Update CHANGELOG.md #24801 * Update for #28360 #28216 #27830 #28404 #27401 #27122 #27931 #28442 * Update for #28379 * Update CHANGELOG.md for #28281 * Update for #28380 * Update for #27375 * Update for #25695 * Update CHANGELOG.md #27985 * Update CHANGELOG.md - update release date manually until can be scripted * Update CHANGELOG.md revert date change as script available * pre-release script updates --------- Co-authored-by: stephybun <[email protected]> Co-authored-by: catriona-m <[email protected]> Co-authored-by: Wyatt Fry <[email protected]> Co-authored-by: sreallymatt <[email protected]> Co-authored-by: Matthew Frahry <[email protected]> Co-authored-by: kt <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Community Note
Description
Add support for Machine Learning Workspace Private Endpoint Network Outbound Rule :
azurerm_machine_learning_workspace_network_outbound_rule_fqdn
)PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource
- support for thething1
property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.