add optional arguments for Oracle VMCluster creation (domain and scan listener ports)

[chanstev]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

• Add new optional arguments for Oracle VMCluster creation and updated related documents
  • domain
  • scan_listener_port_tcp
  • scan_listener_port_tcp_ssl

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_oracle_cloud_vm_cluster - support for the domain, scan_listener_port_tcp, scan_listener_port_tcp_ssl arguments

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[CorrenSoft]

I think that you are missing to process the new properties on the Update method (thus, they will never get updated).

[chanstev]

As the new arguments are all ForceNew now, they will never get updated.

[chanstev]

@CorrenSoft @eelhomsi @katbyte are we good to go now?

[stephybun]

Does the service generate a value for this if the user doesn't set it?

[stephybun]

@chanstev this comment hasn't been addressed

[chanstev]

@stephybun yes, it's optional and control plane will return a generated value for it.

[chanstev]

@stephybun removed StringIsNotEmpty for optional arguments

[stephybun]

Is an empty string "" a valid and accepted value for domain or zone_id?

[chanstev]

@stephybun yes, it's accepted and we tested it.

[chanstev]

@katbyte @stephybun is it all good now?

[chanstev]

All changes are re-tested successfully FYR

[stephybun]

Thanks @chanstev LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.