Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blueprints: swap to go-azure-sdk #21569

Merged
merged 12 commits into from
Aug 4, 2023
Merged

blueprints: swap to go-azure-sdk #21569

merged 12 commits into from
Aug 4, 2023

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Apr 27, 2023

No description provided.

@tombuildsstuff tombuildsstuff force-pushed the kt/blueprint-for-pandora branch from 15df9da to 5eac7b6 Compare April 27, 2023 11:46
@tombuildsstuff
Copy link
Contributor

Cherry-picked/rebased atop of main

@jackofallops jackofallops self-assigned this Jun 26, 2023
tombuildsstuff
tombuildsstuff approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @katbyte

Thanks for this PR.

I've pushed a commit to fix the authorizer when building the client so that the tests can run properly, and then taken a look through and left some comments inline - but on the whole this is looking pretty good. Since I'd pushed the commit to fix the authorizer, I'm going to push another commit to fix this PR up, but otherwise I think this is good to go 👍

Thanks!

internal/services/blueprints/blueprint_assignment_resource.go Outdated Show resolved Hide resolved
internal/services/blueprints/blueprint_assignment_resource.go Outdated Show resolved Hide resolved
internal/services/blueprints/blueprint_assignment_resource.go Outdated Show resolved Hide resolved
internal/services/blueprints/client/client.go Outdated Show resolved Hide resolved
internal/services/blueprints/client/client.go Outdated Show resolved Hide resolved
internal/services/blueprints/client/client.go Outdated Show resolved Hide resolved
internal/services/blueprints/client/client.go Show resolved Hide resolved
internal/services/blueprints/client/client.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v3.69.0 milestone Aug 4, 2023
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2023-08-04 at 10 59 26

@tombuildsstuff tombuildsstuff merged commit ecffcd6 into main Aug 4, 2023
@tombuildsstuff tombuildsstuff deleted the kt/blueprint-for-pandora branch August 4, 2023 09:00
tombuildsstuff added a commit that referenced this pull request Aug 4, 2023
@tombuildsstuff
updating to include #21569
2e82793
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies documentation service/blueprints size/XL
Projects
None yet
Milestone
v3.69.0
Development

Successfully merging this pull request may close these issues.
3 participants
@katbyte @tombuildsstuff @jackofallops