Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New DataSource: azurerm_container_app #21199

Merged
merged 1 commit into from
Mar 30, 2023
Merged

New DataSource: azurerm_container_app #21199

merged 1 commit into from
Mar 30, 2023

Conversation

jiaweitao001
Copy link
Contributor

All tests passed.

=== RUN   TestAccContainerAppDataSource_basic
=== PAUSE TestAccContainerAppDataSource_basic
=== CONT  TestAccContainerAppDataSource_basic
--- PASS: TestAccContainerAppDataSource_basic (727.75s)
PASS

mbfrahry
mbfrahry approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @jiaweitao001

@mbfrahry mbfrahry added this to the v3.50.0 milestone Mar 30, 2023
@mbfrahry mbfrahry changed the title azurerm_container_app: Add support for data source azurerm_container_app New DataSource: azurerm_container_app Mar 30, 2023
@mbfrahry mbfrahry merged commit 24433a3 into hashicorp:main Mar 30, 2023
mbfrahry added a commit that referenced this pull request Mar 30, 2023
@mbfrahry
Update CHANGELOG.md for #21199
b5e6361
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@GraemeMeyerGT
Copy link

@mbfrahry / @jiaweitao001 does a documentation page exist for this resource yet? I can't find it, but not sure if the documentation label means that's still to-do.

@jiaweitao001
Copy link
Contributor Author

Hi @GraemeMeyerGT , is this the doc page you're looking for?

@GraemeMeyerGT
Copy link

Yes it is! Thank you. I failed to scroll far enough in the sidebar after search 🤦‍♀️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
v3.50.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jiaweitao001 @GraemeMeyerGT @mbfrahry