Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_orchestrated_virtual_machine_scale_set - Add Priority_Mix property #20618

Merged
merged 4 commits into from
Mar 1, 2023
Merged

azurerm_orchestrated_virtual_machine_scale_set - Add Priority_Mix property #20618

merged 4 commits into from
Mar 1, 2023

Conversation

aleclawlor
Copy link
Contributor

Adds the PriorityMixPolicy property to VMSS with Flexible Orchestration mode. This property allows customers to specify target splits between regular and Spot priority VMs within a scale set. It consists of two sub properties:

  1. BaseRegularPriorityCount: The minimum number of regular priority VMs in the scale set
  2. RegularPriorityPercentageAboveBase: The desired percentage of VMs that are of regular priority after the base count has been reached

The property has already been added to Azure CLI, PowerShell, and SDKs, including the Go SDK.

@aleclawlor
Copy link
Contributor Author

aleclawlor commented Feb 23, 2023 •
edited
Loading

This property is only available for VMSS with Flexible orchestration mode. Based on the documentation here it looks like the "orchestrated" virtual machine scale set is the mechanism for creating a VMSS with Flexible orchestration. The other two .go files (linux VMScaleSet, Windows VMScaleSet) for creating VMSS create VMSS w/ uniform orchestration only. And it looks like "azure_virtual_machine_scale_set" is being deprecated in favor of these two.

@aleclawlor aleclawlor marked this pull request as ready for review February 24, 2023 22:05
@WodansSon WodansSon self-assigned this Mar 1, 2023
@WodansSon WodansSon added the service/vmss Virtual Machine Scale Sets label Mar 1, 2023
@WodansSon WodansSon changed the title Add PriorityMixPolicy property For VMSS Flex azurerm_orchestrated_virtual_machine_scale_set - Add PriorityMixPolicy property Mar 1, 2023
WodansSon
WodansSon requested changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleclawlor, thank for this PR. This is looking really good, however I did leave a few very minor comments to be addressed. Other than that this LGTM! Awesome job! 🚀

internal/services/compute/orchestrated_virtual_machine_scale_set.go Outdated Show resolved Hide resolved
internal/services/compute/orchestrated_virtual_machine_scale_set_resource.go Outdated Show resolved Hide resolved
internal/services/compute/orchestrated_virtual_machine_scale_set_resource.go Outdated Show resolved Hide resolved
internal/services/compute/orchestrated_virtual_machine_scale_set_resource.go Outdated Show resolved Hide resolved
internal/services/compute/orchestrated_virtual_machine_scale_set_resource.go Outdated Show resolved Hide resolved
internal/services/compute/orchestrated_virtual_machine_scale_set_resource_test.go Outdated Show resolved Hide resolved
website/docs/r/orchestrated_virtual_machine_scale_set.html.markdown Outdated Show resolved Hide resolved
website/docs/r/orchestrated_virtual_machine_scale_set.html.markdown Outdated Show resolved Hide resolved
website/docs/r/orchestrated_virtual_machine_scale_set.html.markdown Outdated Show resolved Hide resolved
@WodansSon WodansSon changed the title azurerm_orchestrated_virtual_machine_scale_set - Add PriorityMixPolicy property azurerm_orchestrated_virtual_machine_scale_set - Add Priority_Mix property Mar 1, 2023
@aleclawlor aleclawlor requested review from WodansSon March 1, 2023 20:00
@aleclawlor aleclawlor closed this Mar 1, 2023
@aleclawlor aleclawlor reopened this Mar 1, 2023
WodansSon
WodansSon approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleclawlor, thanks for pushing those changes... LGTM! 🚀

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit 501e872 into hashicorp:main Mar 1, 2023
@WodansSon WodansSon added this to the v3.46.0 milestone Mar 1, 2023
WodansSon added a commit that referenced this pull request Mar 1, 2023
@WodansSon
updating to include #20618
6d26e26
WodansSon added a commit that referenced this pull request Mar 1, 2023
@WodansSon
fixed casing for #20618
ed6c852
WodansSon added a commit that referenced this pull request Mar 1, 2023
@WodansSon
fixed casing again for #20618
a89b236
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This functionality has been released in v3.46.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mlalic mlalic mlalic approved these changes

@WodansSon WodansSon Awaiting requested review from WodansSon

Assignees

@WodansSon WodansSon

Labels
documentation service/vmss Virtual Machine Scale Sets size/XL
Projects
None yet
Milestone
v3.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aleclawlor @WodansSon @mlalic