-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kusto_cluster_customer_managed_key
- support auto key rotation
#20583
Conversation
liuwuliuyun
commented
Feb 21, 2023
- Fixes Support for setting azure data explorer cmk provider to auto key rotation (no key version) #20569
- Change property key_version to optional
- Change TestAccKustoClusterCustomerManagedKey_basic
- Add TestAccKustoClusterCustomerManagedKey_complete
GOROOT=C:\Program Files\Go #gosetup Process finished with the exit code 0 |
GOROOT=C:\Program Files\Go #gosetup Process finished with the exit code 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @liuwuliuyun but we have some test failures
------- Stdout: -------
=== RUN TestAccKustoClusterCustomerManagedKey_updateKey
=== PAUSE TestAccKustoClusterCustomerManagedKey_updateKey
=== CONT TestAccKustoClusterCustomerManagedKey_updateKey
testcase.go:110: Step 1/4 error: Check failed: Check 4/4 error: azurerm_kusto_cluster_customer_managed_key.test: Attribute 'key_version' expected to be set
--- FAIL: TestAccKustoClusterCustomerManagedKey_updateKey (1028.35s)
FAIL
------- Stdout: -------
=== RUN TestAccKustoClusterCustomerManagedKey_requiresImport
=== PAUSE TestAccKustoClusterCustomerManagedKey_requiresImport
=== CONT TestAccKustoClusterCustomerManagedKey_requiresImport
testcase.go:110: Step 1/2 error: Check failed: Check 4/4 error: azurerm_kusto_cluster_customer_managed_key.test: Attribute 'key_version' expected to be set
--- FAIL: TestAccKustoClusterCustomerManagedKey_requiresImport (1030.75s)
FAIL
GOROOT=C:\Program Files\Go #gosetup Process finished with the exit code 0 |
GOROOT=C:\Program Files\Go #gosetup Process finished with the exit code 0 |
GOROOT=C:\Program Files\Go #gosetup Process finished with the exit code 0 |
GOROOT=C:\Program Files\Go #gosetup Process finished with the exit code 0 |
Thanks @stephybun for the review. I have updated the code and rerun tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liuwuliuyun LGTM 🍊
This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |