Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_cluster_customer_managed_key - support auto key rotation #20583

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

liuwuliuyun
Copy link
Contributor

@liuwuliuyun
Copy link
Contributor Author

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoClusterCustomerManagedKey_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoClusterCustomerManagedKey_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoClusterCustomerManagedKey_basic\E$ #gosetup
=== RUN TestAccKustoClusterCustomerManagedKey_basic
=== PAUSE TestAccKustoClusterCustomerManagedKey_basic
=== CONT TestAccKustoClusterCustomerManagedKey_basic
--- PASS: TestAccKustoClusterCustomerManagedKey_basic (1520.65s)
PASS

Process finished with the exit code 0

@liuwuliuyun
Copy link
Contributor Author

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoClusterCustomerManagedKey_complete_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoClusterCustomerManagedKey_complete_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoClusterCustomerManagedKey_complete\E$ #gosetup
=== RUN TestAccKustoClusterCustomerManagedKey_complete
=== PAUSE TestAccKustoClusterCustomerManagedKey_complete
=== CONT TestAccKustoClusterCustomerManagedKey_complete
--- PASS: TestAccKustoClusterCustomerManagedKey_complete (1251.41s)
PASS

Process finished with the exit code 0

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @liuwuliuyun but we have some test failures

------- Stdout: -------
=== RUN   TestAccKustoClusterCustomerManagedKey_updateKey
=== PAUSE TestAccKustoClusterCustomerManagedKey_updateKey
=== CONT  TestAccKustoClusterCustomerManagedKey_updateKey
testcase.go:110: Step 1/4 error: Check failed: Check 4/4 error: azurerm_kusto_cluster_customer_managed_key.test: Attribute 'key_version' expected to be set
--- FAIL: TestAccKustoClusterCustomerManagedKey_updateKey (1028.35s)
FAIL
------- Stdout: -------
=== RUN   TestAccKustoClusterCustomerManagedKey_requiresImport
=== PAUSE TestAccKustoClusterCustomerManagedKey_requiresImport
=== CONT  TestAccKustoClusterCustomerManagedKey_requiresImport
testcase.go:110: Step 1/2 error: Check failed: Check 4/4 error: azurerm_kusto_cluster_customer_managed_key.test: Attribute 'key_version' expected to be set
--- FAIL: TestAccKustoClusterCustomerManagedKey_requiresImport (1030.75s)
FAIL

@liuwuliuyun
Copy link
Contributor Author

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoClusterCustomerManagedKey_requiresImport_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoClusterCustomerManagedKey_requiresImport_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoClusterCustomerManagedKey_requiresImport\E$ #gosetup
=== RUN TestAccKustoClusterCustomerManagedKey_requiresImport
=== PAUSE TestAccKustoClusterCustomerManagedKey_requiresImport
=== CONT TestAccKustoClusterCustomerManagedKey_requiresImport
--- PASS: TestAccKustoClusterCustomerManagedKey_requiresImport (1354.59s)
PASS

Process finished with the exit code 0

@liuwuliuyun
Copy link
Contributor Author

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoClusterCustomerManagedKey_updateKey_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoClusterCustomerManagedKey_updateKey_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoClusterCustomerManagedKey_updateKey\E$ #gosetup
=== RUN TestAccKustoClusterCustomerManagedKey_updateKey
=== PAUSE TestAccKustoClusterCustomerManagedKey_updateKey
=== CONT TestAccKustoClusterCustomerManagedKey_updateKey
--- PASS: TestAccKustoClusterCustomerManagedKey_updateKey (1312.70s)
PASS

Process finished with the exit code 0

@liuwuliuyun
Copy link
Contributor Author

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand__TestAccKustoClusterCustomerManagedKey_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto__1.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand__TestAccKustoClusterCustomerManagedKey_basic_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto__1.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoClusterCustomerManagedKey_basic\E$ #gosetup
=== RUN TestAccKustoClusterCustomerManagedKey_basic
=== PAUSE TestAccKustoClusterCustomerManagedKey_basic
=== CONT TestAccKustoClusterCustomerManagedKey_basic
--- PASS: TestAccKustoClusterCustomerManagedKey_basic (1248.85s)
PASS

Process finished with the exit code 0

@liuwuliuyun
Copy link
Contributor Author

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand__TestAccKustoClusterCustomerManagedKey_complete_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto__1.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand__TestAccKustoClusterCustomerManagedKey_complete_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto__1.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoClusterCustomerManagedKey_complete\E$ #gosetup
=== RUN TestAccKustoClusterCustomerManagedKey_complete
=== PAUSE TestAccKustoClusterCustomerManagedKey_complete
=== CONT TestAccKustoClusterCustomerManagedKey_complete
--- PASS: TestAccKustoClusterCustomerManagedKey_complete (1226.81s)
PASS

Process finished with the exit code 0

@liuwuliuyun
Copy link
Contributor Author

Thanks @stephybun for the review. I have updated the code and rerun tests.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun LGTM 🍊

@stephybun stephybun merged commit 81232fd into hashicorp:main Feb 22, 2023
@github-actions github-actions bot added this to the v3.45.0 milestone Feb 22, 2023
stephybun added a commit that referenced this pull request Feb 22, 2023
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
@liuwuliuyun liuwuliuyun deleted the fix-20569 branch September 19, 2024 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for setting azure data explorer cmk provider to auto key rotation (no key version)
2 participants