Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_stream_analytics_output_mssql: Username and password parameters optional if MSI authentication #19696

Conversation

marcgs
Copy link
Contributor

@marcgs marcgs commented Dec 15, 2022

username and password parameters are optional when authenticationMode is MSI (Managed Service Identity).

Acceptance tests were adapted and run successfully:

TF_ACC=1 go test -v ./internal/services/streamanalytics -run=TestAccStreamAnalyticsOutputSql -timeout 20m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccStreamAnalyticsOutputSql_basic
=== PAUSE TestAccStreamAnalyticsOutputSql_basic
=== RUN   TestAccStreamAnalyticsOutputSql_update
=== PAUSE TestAccStreamAnalyticsOutputSql_update
=== RUN   TestAccStreamAnalyticsOutputSql_authenticationModeMsi
=== PAUSE TestAccStreamAnalyticsOutputSql_authenticationModeMsi
=== RUN   TestAccStreamAnalyticsOutputSql_requiresImport
=== PAUSE TestAccStreamAnalyticsOutputSql_requiresImport
=== RUN   TestAccStreamAnalyticsOutputSql_maxBatchCountAndMaxWriterCount
=== PAUSE TestAccStreamAnalyticsOutputSql_maxBatchCountAndMaxWriterCount
=== CONT  TestAccStreamAnalyticsOutputSql_basic
=== CONT  TestAccStreamAnalyticsOutputSql_requiresImport
=== CONT  TestAccStreamAnalyticsOutputSql_maxBatchCountAndMaxWriterCount
=== CONT  TestAccStreamAnalyticsOutputSql_authenticationModeMsi
=== CONT  TestAccStreamAnalyticsOutputSql_update
--- PASS: TestAccStreamAnalyticsOutputSql_basic (281.75s)
--- PASS: TestAccStreamAnalyticsOutputSql_authenticationModeMsi (322.58s)
--- PASS: TestAccStreamAnalyticsOutputSql_requiresImport (348.95s)
--- PASS: TestAccStreamAnalyticsOutputSql_update (367.62s)
--- PASS: TestAccStreamAnalyticsOutputSql_maxBatchCountAndMaxWriterCount (534.90s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/streamanalytics       537.343s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@katbyte katbyte merged commit 0bfe285 into hashicorp:main Dec 16, 2022
katbyte added a commit that referenced this pull request Dec 16, 2022
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants