Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_lb - Fix adding/removing a frontend configuration forces recreation of loadbalancer issue #19548

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Dec 5, 2022

After checking the behavior of API and Portal, in fact, it is possible to add/remove frontend configurations for existing loadbalancer, but the zones of existing frontend configuration could not be updated. So submitted this PR to set ForceNew to true when the zones of the existing frontend configuration changes.

Fix #19260.

Test Result:
PASS: TestAccAzureRMLoadBalancer_zonesSingle (662.43s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛈️

@katbyte katbyte merged commit a4023a4 into hashicorp:main Dec 5, 2022
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 5, 2022
katbyte added a commit that referenced this pull request Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sinbai sinbai deleted the loadbalancer/fix_issue_19260 branch December 20, 2022 02:17
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_lb Adding a frontend configuration forces recreation of loadbalancer
2 participants