Support Upload creation_type with uploadSizeBytes

[harshavmb]

Support Upload as one of the create_option. To be used in combination with upload_size_bytes.
Helpful to upload VHD disks from On-Prem <-> Azure, Azure <-> Azure etc.,

[mbfrahry]

Hey @harshavmb. This looks mostly good but there are a few big things that we need to fix before merging.

The test is failing with:

=== CONT  TestAccManagedDisk_upload
testcase.go:110: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) {
}
(map[string]string) (len=1) {
(string) (len=17) "upload_size_bytes": (string) (len=11) "21475885568"
}
--- FAIL: TestAccManagedDisk_upload (244.56s)

This is because we aren't setting it in resourceManagedDiskRead so you'll want to add that too

[harshavmb]

Hey @harshavmb. This looks mostly good but there are a few big things that we need to fix before merging.

The test is failing with:

=== CONT  TestAccManagedDisk_upload
testcase.go:110: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) {
}
(map[string]string) (len=1) {
(string) (len=17) "upload_size_bytes": (string) (len=11) "21475885568"
}
--- FAIL: TestAccManagedDisk_upload (244.56s)

This is because we aren't setting it in resourceManagedDiskRead so you'll want to add that too

Hey @harshavmb. This looks mostly good but there are a few big things that we need to fix before merging.

The test is failing with:

=== CONT  TestAccManagedDisk_upload
testcase.go:110: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) {
}
(map[string]string) (len=1) {
(string) (len=17) "upload_size_bytes": (string) (len=11) "21475885568"
}
--- FAIL: TestAccManagedDisk_upload (244.56s)

This is because we aren't setting it in resourceManagedDiskRead so you'll want to add that too

Thanks @mbfrahry for your review. Indeed, I missed to update resourceManagedDiskRead function.
Regarding resourceManagedDiskUpdate, I don't think updates are supported as I see no support in SDK for UploadSizeBytes in DiskUpdate struct here.

So, to avoid that what I've done is whenever, upload_size_bytes is changed, we force to create a new disk with the requested size. I think this makes sense as the disk is in unattached state & doesn't have any data to lose. So, could be created as many times as we can to copy the data.

[stephybun]

Test looks good now @harshavmb, just some remaining suggestions on the docs then this should be good to go!

[harshavmb]

Test looks good now @harshavmb, just some remaining suggestions on the docs then this should be good to go!

hi @stephybun ,

Committed changes as per the review.

[stephybun]

Thanks @harshavmb LGTM 👍

[github-actions]

This functionality has been released in v3.34.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.