Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_data_factory_dataset_parquet - mark path as optional #19009

Merged
merged 2 commits into from
Oct 27, 2022
Merged

azurerm_data_factory_dataset_parquet - mark path as optional #19009

merged 2 commits into from
Oct 27, 2022

Conversation

ms-henglu
Copy link
Contributor

@ms-henglu ms-henglu commented Oct 27, 2022 •
edited
Loading

fixes #18995
image

stephybun
stephybun requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test for this scenario?

@ms-henglu
Copy link
Contributor Author

Hi @stephybun - Thanks for the code review. I've modified some tests, so they can test this scenario.

stephybun
stephybun approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu LGTM 🌟

@stephybun stephybun added the bug label Oct 27, 2022
@stephybun stephybun merged commit df78c9e into hashicorp:main Oct 27, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 27, 2022
stephybun added a commit that referenced this pull request Oct 27, 2022
@stephybun
Update for #19009
e6bf2e9
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
bug documentation service/data-factory
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.

azure_blob_storage_location.path should be optional for azurerm_data_factory_dataset_parquet
2 participants
@ms-henglu @stephybun