Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_mssql_database - add support for maintenance_configuration_name #18247

Merged
merged 1 commit into from
Sep 9, 2022
Merged

azurerm_mssql_database - add support for maintenance_configuration_name #18247

merged 1 commit into from
Sep 9, 2022

Conversation

richardfric
Copy link
Contributor

@richardfric richardfric commented Sep 5, 2022 •
edited
Loading

This PR solves #14520

@github-actions github-actions bot added documentation service/mssql Microsoft SQL Server labels Sep 5, 2022
@richardfric richardfric changed the title mssql_database - add support for maintenance_configuration_name azurerm_mssql_database - add support for maintenance_configuration_name Sep 5, 2022
dkuzmenok
dkuzmenok reviewed Sep 5, 2022
View reviewed changes
internal/services/mssql/mssql_database_resource.go
@@ -234,6 +236,7 @@ func resourceMsSqlDatabaseCreateUpdate(d *pluginsdk.ResourceData, meta interface
SampleName: sql.SampleName(d.Get("sample_name").(string)),
RequestedBackupStorageRedundancy: sql.RequestedBackupStorageRedundancy(d.Get("storage_account_type").(string)),
ZoneRedundant: utils.Bool(d.Get("zone_redundant").(bool)),
MaintenanceConfigurationID: utils.String(maintenanceConfigId.ID()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintenanceConfigId cannot be nil here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintenanceConfigId has at least SQL_Default value (if not explicitly set)

@richardfric richardfric changed the title azurerm_mssql_database - add support for maintenance_configuration_name azurerm_mssql_database - add support for maintenance_configuration_name Sep 6, 2022
katbyte
katbyte approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌻

@katbyte katbyte merged commit 273d4a2 into hashicorp:main Sep 9, 2022
katbyte added a commit that referenced this pull request Sep 9, 2022
@katbyte
CHANGELOG #18247
25fae47
@github-actions github-actions bot added this to the v3.22.0 milestone Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This functionality has been released in v3.22.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@richardfric richardfric deleted the mssql_database_maintenance_configuration_name branch September 9, 2022 05:31
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dkuzmenok dkuzmenok dkuzmenok left review comments

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/mssql Microsoft SQL Server
Projects
None yet
Milestone
v3.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richardfric @katbyte @dkuzmenok