Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: private_dns_zone_virtual_network_link #18045

Merged
merged 3 commits into from
Sep 15, 2022
Merged

New Data Source: private_dns_zone_virtual_network_link #18045

merged 3 commits into from
Sep 15, 2022

Conversation

skatsaounis
Copy link
Contributor

Resolves: #17760

@skatsaounis skatsaounis changed the title [WIP] New Data Source: private_dns_zone_virtual_network_link New Data Source: private_dns_zone_virtual_network_link Aug 25, 2022
@skatsaounis
Copy link
Contributor Author

Test is successful:

% go test . -v -run "TestAccDataSourcePrivateDnsZoneVirtualNetworkLink_basic"
=== RUN   TestAccDataSourcePrivateDnsZoneVirtualNetworkLink_basic
=== PAUSE TestAccDataSourcePrivateDnsZoneVirtualNetworkLink_basic
=== CONT  TestAccDataSourcePrivateDnsZoneVirtualNetworkLink_basic
--- PASS: TestAccDataSourcePrivateDnsZoneVirtualNetworkLink_basic (418.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/privatedns	419.532s

@skatsaounis
Copy link
Contributor Author

@katbyte another one in the DNS family. Feel free to review 😃

katbyte
katbyte approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skatsaounis ! LGTM 🔝

@katbyte katbyte merged commit 3d53f35 into hashicorp:main Sep 15, 2022
katbyte added a commit that referenced this pull request Sep 15, 2022
@katbyte
CHANGELOG #18045
db92469
@github-actions github-actions bot added this to the v3.23.0 milestone Sep 15, 2022
@github-actions
Copy link

This functionality has been released in v3.23.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/dns
Projects
None yet
Milestone
v3.23.0
Development

Successfully merging this pull request may close these issues.

Support for data source on azurerm_private_dns_zone_virtual_network_link resource
2 participants
@skatsaounis @katbyte