Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_server automatically sets minimum_tls_version even if not provided #16565

Closed
1 task done
schauppm opened this issue Apr 27, 2022 · 3 comments
Closed
1 task done
Labels
service/mssql Microsoft SQL Server v/3.x

Comments

@schauppm
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.1.5

AzureRM Provider Version

3.3.0

Affected Resource(s)/Data Source(s)

azurerm_mssql_server

Terraform Configuration Files

resource "azurerm_mssql_server" "example" {
  name                         = "mssqlserver"
  resource_group_name          = "mssqlserver"
  location                     = "westeurope"
  version                      = "12.0"
  administrator_login          = "missadministrator"
  administrator_login_password = "thisIsKat11"
}

Debug Output/Panic Output

# module.mssql-server.azurerm_mssql_server.primary will be created
  + resource "azurerm_mssql_server" "example" {
      + administrator_login                  = "missadministrator"
      + administrator_login_password         = (sensitive value)
      + connection_policy                    = "Default"
      + fully_qualified_domain_name          = (known after apply)
      + id                                   = (known after apply)
      + location                             = "westeurope"
      + minimum_tls_version                  = "1.2"
      + name                                 = "mssqlserver"
      + outbound_network_restriction_enabled = false
      + primary_user_assigned_identity_id    = (known after apply)
      + public_network_access_enabled        = true
      + resource_group_name                  = "mssqlserver"

Expected Behaviour

My expectaion is that a MSSQL server is created without any minimum TLS setting applied.
According to the documentation, any settings that have a default value applied are listed as such.
minimum_tls_version does not have a default value according to the doc: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/mssql_server

Actual Behaviour

If I don't provide "minimum_tls_version", the minimum_tls_version 1.2 is applied per default. If I provide minimum_tls_version = "1.0" is is exactly applied as such.

I can create a MSSQL server without minimum TLS settings through Azure portal.

I can also create a MSSQL server without minumim TLS settings through terraform with azurerm provider 2.99, I have not checked any other provider versions yet

Steps to Reproduce

No response

Important Factoids

No response

References

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/mssql_server

@sinbai
Copy link
Contributor

sinbai commented Apr 29, 2022

@schauppm thank you for posting this issue here. I have submitted PR #16595 to resolve this issue. Please track it for updates.

@rcskosir rcskosir added the service/mssql Microsoft SQL Server label Jun 9, 2023
@rcskosir
Copy link
Contributor

rcskosir commented Jun 9, 2023

@schauppm Thank you for opening this issue. @sinbai Thank you for your PR #16595 that resolves this issue. As such, I will mark this issue as closed.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/mssql Microsoft SQL Server v/3.x
Projects
None yet
Development

No branches or pull requests

4 participants