Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_policy_assignment #16527

Merged
merged 3 commits into from
Jun 15, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 24, 2022

This PR implements a new data source azurerm_policy_assignment.

NOTE: Currently, this PR is depending on a local version of github.com/hashicorp/go-azure-helpers package. Until, hashicorp/go-azure-helpers#112 is merged, we can change to using the upstream one and go on reviewing this PR.

Fixes #16491.

Test

> TF_ACC=1 go test -v -timeout=20h ./internal/services/policy -run='TestAccDataSourceAssignment_builtinPolicy|TestAccDataSourceAssignment_identity'
=== RUN   TestAccDataSourceAssignment_builtinPolicyBasic
=== PAUSE TestAccDataSourceAssignment_builtinPolicyBasic
=== RUN   TestAccDataSourceAssignment_builtinPolicyComplete
=== PAUSE TestAccDataSourceAssignment_builtinPolicyComplete
=== RUN   TestAccDataSourceAssignment_identity
=== PAUSE TestAccDataSourceAssignment_identity
=== CONT  TestAccDataSourceAssignment_builtinPolicyBasic
=== CONT  TestAccDataSourceAssignment_identity
=== CONT  TestAccDataSourceAssignment_builtinPolicyComplete
--- PASS: TestAccDataSourceAssignment_builtinPolicyBasic (248.56s)
--- PASS: TestAccDataSourceAssignment_builtinPolicyComplete (306.67s)
--- PASS: TestAccDataSourceAssignment_identity (438.85s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/policy        438.866s

@magodo magodo changed the title WIP: New Data Source: azurerm_policy_assignment New Data Source: azurerm_policy_assignment Jun 15, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍁

@katbyte katbyte merged commit eb0de68 into hashicorp:main Jun 15, 2022
katbyte added a commit that referenced this pull request Jun 15, 2022
@github-actions github-actions bot added this to the v3.11.0 milestone Jun 15, 2022
@github-actions
Copy link

This functionality has been released in v3.11.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Policy Assignment Data Source
2 participants