Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_conditional_access_policy: support sign_in_frequency_authentication_type and sign_in_frequency_interval #1229

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

manicminer
Copy link
Contributor

Additionally, remove the conditional ForceNew for session_controls and devices blocks, now that that the API consistently accepts null values for these objects.

Also add plan-time validation for an ineffectual session_controls block when grant_controls has not been set.

And fix up some tests.

Depends on: manicminer/hamilton#263
Closes: #1225

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌧️

@manicminer
Copy link
Contributor Author

Test results (failure unrelated)

Screenshot 2023-10-27 at 00 09 20

…nd `sign_in_frequency_interval`

Additionally, remove the conditional ForceNew for `session_controls` and
`devices` blocks, now that that the API consistently accepts `null` values
for these objects.

Also add plan-time validation for an ineffectual `session_controls`
block when `grant_controls` has not been set.

And fix up some tests.
@manicminer manicminer force-pushed the f/cap-signinfrequency branch from d59a157 to ea3561b Compare October 26, 2023 23:31
@manicminer manicminer merged commit 7ac7168 into main Oct 26, 2023
@manicminer manicminer deleted the f/cap-signinfrequency branch October 26, 2023 23:34
manicminer added a commit that referenced this pull request Oct 26, 2023
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Oct 30, 2023
<Actions>
<action
id="c2aadc6326b4b0bc58df11ee286b0f67ccdb5888bd77f391e6473570113337ec">
        <h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azuread&#34; updated from &#34;2.44.1&#34; to
&#34;2.45.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.45.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.45.0&#xA;FEATURES:&#xA;&#xA;*
**New Resource:** `azuread_application_optional_claims`
([#1223](https://github.com/hashicorp/terraform-provider-azuread/issues/1223))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
`azuread_conditional_access_policy` - improved plan-time validation for
the `session_controls` block
([#1229](hashicorp/terraform-provider-azuread#1229
`azuread_conditional_access_policy` - support for the
`sign_in_frequency_authentication_type` and `sign_in_frequency_interval`
properties in the `session_controls` block
([#1229](hashicorp/terraform-provider-azuread#1229
`azuread_conditional_access_policy` - support for the
`included_guests_or_external_users` and
`excluded_guests_or_external_users` blocks in the `users` block
([#1222](https://github.com/hashicorp/terraform-provider-azuread/issues/1222))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azuread_conditional_access_policy` - removing the
`devices` or `session_controls` blocks will no longer force a new
resource to be created
([#1229](https://github.com/hashicorp/terraform-provider-azuread/issues/1229))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sign_in_frequency 'Every time' parameter
2 participants