Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support VPC sharing #6630

Closed
ewbankkit opened this issue Nov 28, 2018 · 4 comments · Fixed by #6642
Closed

Feature request: Support VPC sharing #6630

ewbankkit opened this issue Nov 28, 2018 · 4 comments · Fixed by #6642
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 28, 2018

With VPC sharing, you can now allow multiple accounts in the same AWS Organization to launch their application resources, like EC2 instances, RDS databases, and Redshift clusters into shared, centrally managed VPCs.

User Guide.

Requires:

Related:

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Nov 28, 2018

Will involve adding an owner_id attribute to the:

  • aws_vpc_dhcp_options
  • aws_internet_gateway
  • aws_network_acl
  • aws_route_table
  • aws_subnet - Also add arn attribute for use with RAM (arn is already a Subnet attribute)
  • aws_vpc

resources and data sources.
Plus adding support for the Availability Zone ID to Subnet creation.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 1, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 4, 2018
@bflad
Copy link
Contributor

bflad commented Dec 4, 2018

The following enhancements have been merged and will release with version 1.51.0 of the AWS provider, likely in the next day or two. 👍 Thanks @ewbankkit!

  • data-source/aws_internet_gateway: Add owner_id attribute
  • data-source/aws_route_table: Add owner_id attribute
  • data-source/aws_subnet: Add availability_zone_id argument and owner_id attribute
  • data-source/aws_subnet: Use API provided arn attribute
  • data-source/aws_vpc: Add owner_id attribute
  • data-source/aws_vpc_dhcp_options: Add owner_id attribute
  • resource/aws_default_network_acl: Add owner_id attribute
  • resource/aws_default_route_table: Add owner_id attribute
  • resource/aws_default_subnet: Add owner_id attribute
  • resource/aws_default_vpc: Add owner_id attribute
  • resource/aws_default_vpc_dhcp_options: Add owner_id attribute
  • resource/aws_internet_gateway: Add owner_id attribute
  • resource/aws_network_acl: Add owner_id attribute
  • resource/aws_route_table: Add owner_id attribute
  • resource/aws_subnet: Add availability_zone_id argument and owner_id attribute
  • resource/aws_subnet: Use API provided arn attribute
  • resource/aws_vpc: Add owner_id attribute
  • resource/aws_vpc_dhcp_options: Add owner_id attribute

@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants