r/aws_gamelift_game_server_group: Correct tagging #41256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
% make testacc TESTARGS='-run=TestAccGameLiftGameServerGroup_tags' PKG=gamelift
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run=TestAccGameLiftGameServerGroup_tags -timeout 360m -vet=off
2025/02/05 16:39:13 Initializing Terraform AWS Provider...
=== RUN TestAccGameLiftGameServerGroup_tags
=== PAUSE TestAccGameLiftGameServerGroup_tags
=== CONT TestAccGameLiftGameServerGroup_tags
game_server_group_test.go:591: Step 3/4 error: Check failed: Check 2/4 error: aws_gamelift_game_server_group.test: Attribute 'tags.%' expected "2", got "1"
--- FAIL: TestAccGameLiftGameServerGroup_tags (233.08s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/gamelift 238.630s
FAIL
make: *** [testacc] Error 1
% make testacc TESTARGS='-run=TestAccGameLiftGameServerGroup_tags' PKG=gamelift make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.5 test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run=TestAccGameLiftGameServerGroup_tags -timeout 360m -vet=off 2025/02/05 17:33:27 Initializing Terraform AWS Provider... === RUN TestAccGameLiftGameServerGroup_tags === PAUSE TestAccGameLiftGameServerGroup_tags === CONT TestAccGameLiftGameServerGroup_tags --- PASS: TestAccGameLiftGameServerGroup_tags (366.45s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/gamelift 371.910s
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
tests
ewbankkit
added
bug
johnsonaj
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccGameLiftGameServerGroup_tags' PKG=gamelift
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/gamelift/... -v -count 1 -parallel 20 -run=TestAccGameLiftGameServerGroup_tags -timeout 360m -vet=off
2025/02/05 18:05:56 Initializing Terraform AWS Provider...
=== RUN TestAccGameLiftGameServerGroup_tags
=== PAUSE TestAccGameLiftGameServerGroup_tags
=== CONT TestAccGameLiftGameServerGroup_tags
--- PASS: TestAccGameLiftGameServerGroup_tags (220.33s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/gamelift 227.055s
|
This functionality has been released in v5.86.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
github-actions
bot
removed
the
prioritized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing
CustomizeDiffleading to incorrecttags_allhandling.Discovered while working on #41253.
Output from Acceptance Testing