Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tagging support for aws_rekognition_project #41192

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Feb 2, 2025

Description

This PR is to add tagging support to the aws_rekognition_project resource.

Relations

Closes #41102

References

Referred to CreateProject for specs.

Output from Acceptance Testing

$ make testacc TESTS=TestAccRekognitionProject_ PKG=rekognition
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/rekognition/... -v -count 1 -parallel 20 -run='TestAccRekognitionProject_'  -timeout 360m -vet=off
2025/02/02 16:08:18 Initializing Terraform AWS Provider...
=== RUN   TestAccRekognitionProject_basic
=== PAUSE TestAccRekognitionProject_basic
=== RUN   TestAccRekognitionProject_ContentModeration
=== PAUSE TestAccRekognitionProject_ContentModeration
=== RUN   TestAccRekognitionProject_CustomLabels
=== PAUSE TestAccRekognitionProject_CustomLabels
=== RUN   TestAccRekognitionProject_disappears
=== PAUSE TestAccRekognitionProject_disappears
=== RUN   TestAccRekognitionProject_tags
=== PAUSE TestAccRekognitionProject_tags
=== CONT  TestAccRekognitionProject_basic
=== CONT  TestAccRekognitionProject_disappears
=== CONT  TestAccRekognitionProject_tags
=== CONT  TestAccRekognitionProject_CustomLabels
=== CONT  TestAccRekognitionProject_ContentModeration
--- PASS: TestAccRekognitionProject_disappears (21.41s)
--- PASS: TestAccRekognitionProject_basic (23.89s)
--- PASS: TestAccRekognitionProject_CustomLabels (24.00s)
--- PASS: TestAccRekognitionProject_ContentModeration (32.27s)
--- PASS: TestAccRekognitionProject_tags (42.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rekognition        43.228s

$

@acwwat acwwat requested a review from a team as a code owner February 2, 2025 21:12
Copy link

github-actions bot commented Feb 2, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/rekognition Issues and PRs that pertain to the rekognition service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Feb 2, 2025
@acwwat acwwat force-pushed the f-aws_rekognition_project-add_tagging_support branch from 89c6810 to 363493a Compare February 2, 2025 21:13
@acwwat acwwat force-pushed the f-aws_rekognition_project-add_tagging_support branch from 363493a to db30ba0 Compare February 2, 2025 21:17
@ewbankkit ewbankkit added tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 3, 2025
@ewbankkit ewbankkit self-assigned this Feb 3, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRekognitionProject_' PKG=rekognition ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/rekognition/... -v -count 1 -parallel 3  -run=TestAccRekognitionProject_ -timeout 360m -vet=off
2025/02/03 08:32:48 Initializing Terraform AWS Provider...
=== RUN   TestAccRekognitionProject_basic
=== PAUSE TestAccRekognitionProject_basic
=== RUN   TestAccRekognitionProject_ContentModeration
=== PAUSE TestAccRekognitionProject_ContentModeration
=== RUN   TestAccRekognitionProject_CustomLabels
=== PAUSE TestAccRekognitionProject_CustomLabels
=== RUN   TestAccRekognitionProject_disappears
=== PAUSE TestAccRekognitionProject_disappears
=== RUN   TestAccRekognitionProject_tags
=== PAUSE TestAccRekognitionProject_tags
=== CONT  TestAccRekognitionProject_basic
=== CONT  TestAccRekognitionProject_disappears
=== CONT  TestAccRekognitionProject_tags
--- PASS: TestAccRekognitionProject_basic (15.03s)
=== CONT  TestAccRekognitionProject_CustomLabels
--- PASS: TestAccRekognitionProject_disappears (15.31s)
=== CONT  TestAccRekognitionProject_ContentModeration
--- PASS: TestAccRekognitionProject_CustomLabels (12.62s)
--- PASS: TestAccRekognitionProject_tags (28.73s)
--- PASS: TestAccRekognitionProject_ContentModeration (18.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rekognition	38.958s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0a61fa0 into hashicorp:main Feb 3, 2025
56 checks passed
@github-actions github-actions bot added this to the v5.85.0 milestone Feb 3, 2025
@acwwat acwwat deleted the f-aws_rekognition_project-add_tagging_support branch February 3, 2025 19:08
Copy link

github-actions bot commented Feb 3, 2025

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/rekognition Issues and PRs that pertain to the rekognition service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_rekognition_project: Add tags
2 participants