Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudwatch_event_connection: Add invocation_connectivity_parameters argument #41144

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 29, 2025

Description

Adds invocation_connectivity_parameters to aws_cloudwatch_event_connection for private API access via VPC Lattice.

Relations

Closes #40384.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccEventsConnection_' PKG=events ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/events/... -v -count 1 -parallel 3  -run=TestAccEventsConnection_ -timeout 360m -vet=off
2025/01/29 15:11:28 Initializing Terraform AWS Provider...
=== RUN   TestAccEventsConnection_apiKey
=== PAUSE TestAccEventsConnection_apiKey
=== RUN   TestAccEventsConnection_basic
=== PAUSE TestAccEventsConnection_basic
=== RUN   TestAccEventsConnection_oAuth
=== PAUSE TestAccEventsConnection_oAuth
=== RUN   TestAccEventsConnection_invocationHTTPParameters
=== PAUSE TestAccEventsConnection_invocationHTTPParameters
=== RUN   TestAccEventsConnection_disappears
=== PAUSE TestAccEventsConnection_disappears
=== RUN   TestAccEventsConnection_invocationConnectivityParameters
=== PAUSE TestAccEventsConnection_invocationConnectivityParameters
=== CONT  TestAccEventsConnection_apiKey
=== CONT  TestAccEventsConnection_invocationHTTPParameters
=== CONT  TestAccEventsConnection_invocationConnectivityParameters
--- PASS: TestAccEventsConnection_invocationHTTPParameters (31.42s)
=== CONT  TestAccEventsConnection_oAuth
--- PASS: TestAccEventsConnection_apiKey (31.88s)
=== CONT  TestAccEventsConnection_disappears
--- PASS: TestAccEventsConnection_disappears (12.99s)
=== CONT  TestAccEventsConnection_basic
--- PASS: TestAccEventsConnection_oAuth (35.14s)
--- PASS: TestAccEventsConnection_basic (23.95s)
--- PASS: TestAccEventsConnection_invocationConnectivityParameters (93.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	98.379s

@ewbankkit ewbankkit requested a review from a team as a code owner January 29, 2025 20:08
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. service/events Issues and PRs that pertain to the events service. service/vpclattice Issues and PRs that pertain to the vpclattice service. labels Jan 29, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 29, 2025
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 29, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=events TESTS=TestAccEventsConnection_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsConnection_'  -timeout 360m -vet=off
2025/01/29 15:48:58 Initializing Terraform AWS Provider...

--- PASS: TestAccEventsConnection_disappears (16.26s)
--- PASS: TestAccEventsConnection_basic (29.44s)
--- PASS: TestAccEventsConnection_apiKey (36.57s)
--- PASS: TestAccEventsConnection_invocationHTTPParameters (36.82s)
--- PASS: TestAccEventsConnection_oAuth (40.87s)
--- PASS: TestAccEventsConnection_invocationConnectivityParameters (79.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     86.579s

Comment on lines +375 to +378
// Handle EventBridge-managed resource association deletion.
const (
timeout = 1 * time.Minute
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed a test failure on my first run of this suite with the error retried below. Not sure if this warrants bumping the default and/or making it configurable?

=== NAME  TestAccEventsConnection_invocationConnectivityParameters
    connection_test.go:596: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting VPCLattice Resource Configuration (rcfg-0ecdf92d7a056f2d1)

        operation error VPC Lattice: DeleteResourceConfiguration, https response
        error StatusCode: 400, RequestID: e4a27088-0707-41c4-a4df-30a71d643c21,
        ValidationException: rcfg-0ecdf92d7a056f2d1 has existing association with
        service networks

@ewbankkit ewbankkit merged commit 9d14284 into main Jan 29, 2025
57 checks passed
@ewbankkit ewbankkit deleted the f-aws_cloudwatch_event_connection.InvocationConnectivityParameters branch January 29, 2025 20:59
@github-actions github-actions bot added this to the v5.85.0 milestone Jan 29, 2025
Copy link

github-actions bot commented Feb 3, 2025

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/events Issues and PRs that pertain to the events service. service/vpclattice Issues and PRs that pertain to the vpclattice service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to VPC resources over AWS PrivateLink
2 participants