-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_cloudwatch_event_connection: Add invocation_connectivity_parameters
argument
#41144
r/aws_cloudwatch_event_connection: Add invocation_connectivity_parameters
argument
#41144
Conversation
…d aws_vpclattice_resource_gateway.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=events TESTS=TestAccEventsConnection_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsConnection_' -timeout 360m -vet=off
2025/01/29 15:48:58 Initializing Terraform AWS Provider...
--- PASS: TestAccEventsConnection_disappears (16.26s)
--- PASS: TestAccEventsConnection_basic (29.44s)
--- PASS: TestAccEventsConnection_apiKey (36.57s)
--- PASS: TestAccEventsConnection_invocationHTTPParameters (36.82s)
--- PASS: TestAccEventsConnection_oAuth (40.87s)
--- PASS: TestAccEventsConnection_invocationConnectivityParameters (79.97s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 86.579s
// Handle EventBridge-managed resource association deletion. | ||
const ( | ||
timeout = 1 * time.Minute | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observed a test failure on my first run of this suite with the error retried below. Not sure if this warrants bumping the default and/or making it configurable?
=== NAME TestAccEventsConnection_invocationConnectivityParameters
connection_test.go:596: Error running post-test destroy, there may be dangling resources: exit status 1
Error: deleting VPCLattice Resource Configuration (rcfg-0ecdf92d7a056f2d1)
operation error VPC Lattice: DeleteResourceConfiguration, https response
error StatusCode: 400, RequestID: e4a27088-0707-41c4-a4df-30a71d643c21,
ValidationException: rcfg-0ecdf92d7a056f2d1 has existing association with
service networks
This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Adds
invocation_connectivity_parameters
toaws_cloudwatch_event_connection
for private API access via VPC Lattice.Relations
Closes #40384.
Output from Acceptance Testing