Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): cluster enabled_cloudwatch_logs_exports doesn't allow instance #41111

Conversation

zbuchheit
Copy link
Contributor

There is a new value instance for aurora-postgresql that is accepted in the enabled_cloudwatch_logs_exports field. It looks like this is currently being rolled out and is only available in some regions (can be tested in us-west-2).

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance'  -timeout 360m -vet=off
2025/01/27 15:05:24 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance (119.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        124.502s

Description

Relations

Closes #41108

References

Similar to #40789

There is a new value `instance` for aurora-postgresql that is accepted in the
`enabled_cloudwatch_logs_exports` field. It looks like this is currently
being rolled out and is only available in some regions (can be tested in
`us-west-2`).

**Output from Acceptance Testing**

```
% make testacc TESTS=TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance'  -timeout 360m -vet=off
2025/01/27 15:05:24 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance (119.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        124.502s
```

closes hashicorp#41108
@zbuchheit zbuchheit requested a review from a team as a code owner January 27, 2025 23:24
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. needs-triage Waiting for first response or review from a maintainer. labels Jan 27, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @zbuchheit 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 28, 2025
@ewbankkit ewbankkit self-assigned this Jan 28, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 28, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCluster_EnabledCloudWatchLogsExports_' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSCluster_EnabledCloudWatchLogsExports_ -timeout 360m -vet=off
2025/01/28 07:19:57 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql
=== RUN   TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance (113.81s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql (113.83s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (333.69s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (2049.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2168.673s

@ewbankkit
Copy link
Contributor

@zbuchheit Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3d416b1 into hashicorp:main Jan 28, 2025
48 checks passed
@github-actions github-actions bot added this to the v5.85.0 milestone Jan 28, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_rds_cluster.enabled_cloudwatch_logs_exports doesn't allow new instance value
2 participants