-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rds): cluster enabled_cloudwatch_logs_exports doesn't allow instance #41111
fix(rds): cluster enabled_cloudwatch_logs_exports doesn't allow instance #41111
Conversation
There is a new value `instance` for aurora-postgresql that is accepted in the `enabled_cloudwatch_logs_exports` field. It looks like this is currently being rolled out and is only available in some regions (can be tested in `us-west-2`). **Output from Acceptance Testing** ``` % make testacc TESTS=TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance PKG=rds make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance' -timeout 360m -vet=off 2025/01/27 15:05:24 Initializing Terraform AWS Provider... === RUN TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance === PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance === CONT TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance --- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance (119.71s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 124.502s ``` closes hashicorp#41108
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @zbuchheit 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSCluster_EnabledCloudWatchLogsExports_' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 3 -run=TestAccRDSCluster_EnabledCloudWatchLogsExports_ -timeout 360m -vet=off
2025/01/28 07:19:57 Initializing Terraform AWS Provider...
=== RUN TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== RUN TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== RUN TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql
=== RUN TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
=== PAUSE TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
=== CONT TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
=== CONT TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql
=== CONT TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql_instance (113.81s)
=== CONT TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_aurora_postgresql (113.83s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (333.69s)
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (2049.16s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 2168.673s
@zbuchheit Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
There is a new value
instance
for aurora-postgresql that is accepted in theenabled_cloudwatch_logs_exports
field. It looks like this is currently being rolled out and is only available in some regions (can be tested inus-west-2
).Output from Acceptance Testing
Description
Relations
Closes #41108
References
Similar to #40789