feat: Add arn attribute to aws_ec2_transit_gateway_peering_attachment resource and data source

[acwwat]

Description

The PR is to add the (calculated) arn attribute to the aws_ec2_transit_gateway_peering_attachment resource and data source.

Relations

Closes #40923 (along with #41084 and #41086)

References

Referred to ARN format in Actions, resources, and condition keys for Amazon EC2 as referenced in the original GitHub issue.

Output from Acceptance Testing

For the aws_ec2_transit_gateway_peering_attachment resource:

$ make testacc TESTS=TestAccTransitGateway_serial/PeeringAttachment_basic PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccTransitGateway_serial/PeeringAttachment_basic'  -timeout 360m -vet=off
2025/01/26 15:49:04 Initializing Terraform AWS Provider...
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/PeeringAttachment_basic
=== PAUSE TestAccTransitGateway_serial/PeeringAttachment_basic
=== CONT  TestAccTransitGateway_serial/PeeringAttachment_basic
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/PeeringAttachment_basic (267.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        267.372s

$

For the aws_ec2_transit_gateway_peering_attachment data source:

$ make testacc TESTS=TestAccTransitGatewayDataSource_serial/PeeringAttachment PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccTransitGatewayDataSource_serial/PeeringAttachment'  -timeout 360m -vet=off
2025/01/26 15:42:54 Initializing Terraform AWS Provider...
=== RUN   TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== CONT  TestAccTransitGatewayDataSource_serial
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachments_Filter
=== PAUSE TestAccTransitGatewayDataSource_serial/PeeringAttachments_Filter
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment_IDDifferentAccount
=== PAUSE TestAccTransitGatewayDataSource_serial/PeeringAttachment_IDDifferentAccount
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment_Tags
=== PAUSE TestAccTransitGatewayDataSource_serial/PeeringAttachment_Tags
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment_FilterSameAccount
=== PAUSE TestAccTransitGatewayDataSource_serial/PeeringAttachment_FilterSameAccount
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment_FilterDifferentAccount
=== PAUSE TestAccTransitGatewayDataSource_serial/PeeringAttachment_FilterDifferentAccount
=== RUN   TestAccTransitGatewayDataSource_serial/PeeringAttachment_IDSameAccount
=== PAUSE TestAccTransitGatewayDataSource_serial/PeeringAttachment_IDSameAccount
=== CONT  TestAccTransitGatewayDataSource_serial/PeeringAttachments_Filter
=== CONT  TestAccTransitGatewayDataSource_serial/PeeringAttachment_FilterSameAccount
=== CONT  TestAccTransitGatewayDataSource_serial/PeeringAttachment_IDSameAccount
=== CONT  TestAccTransitGatewayDataSource_serial/PeeringAttachment_FilterDifferentAccount
=== CONT  TestAccTransitGatewayDataSource_serial/PeeringAttachment_Tags
=== CONT  TestAccTransitGatewayDataSource_serial/PeeringAttachment_IDDifferentAccount
=== NAME  TestAccTransitGatewayDataSource_serial/PeeringAttachment_FilterDifferentAccount
    transitgateway_peering_attachment_data_source_test.go:61: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== NAME  TestAccTransitGatewayDataSource_serial/PeeringAttachment_IDDifferentAccount
    transitgateway_peering_attachment_data_source_test.go:125: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- PASS: TestAccTransitGatewayDataSource_serial (0.00s)
    --- SKIP: TestAccTransitGatewayDataSource_serial/PeeringAttachment_FilterDifferentAccount (0.94s)
    --- SKIP: TestAccTransitGatewayDataSource_serial/PeeringAttachment_IDDifferentAccount (0.95s)
    --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachment_FilterSameAccount (272.80s)
    --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachment_IDSameAccount (303.04s)
    --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachments_Filter (303.54s)
    --- PASS: TestAccTransitGatewayDataSource_serial/PeeringAttachment_Tags (303.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        303.926s

$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PeeringAttachment_basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/PeeringAttachment_basic -timeout 360m -vet=off
2025/01/28 08:01:45 Initializing Terraform AWS Provider...
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/PeeringAttachment_basic
=== PAUSE TestAccTransitGateway_serial/PeeringAttachment_basic
=== CONT  TestAccTransitGateway_serial/PeeringAttachment_basic
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/PeeringAttachment_basic (361.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	367.531s

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!