[Bug]: EC2 public_ip isn't re-read on modifyInstanceAttributeWithStopStart

[nijave]

Terraform Core Version

1.7.5

AWS Provider Version

5.81.0

Affected Resource(s)

aws_instance

Expected Behavior

modifyInstanceAttributeWithStopStart should refresh instance attributes that can change after a stop/start cycle. This mainly effects public_ip

Actual Behavior

Instance attributes that change aren't updated

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_instance" "bastion" {
  ami                         = var.bastion_ami
  instance_type               = var.bastion_instance_type
  associate_public_ip_address = true
  ebs_optimized               = true
  key_name                    = "${var.vpc_name}-${var.bastion_key_name}"
  vpc_security_group_ids      = [var.aws_security_group_bastion_id]
  iam_instance_profile        = aws_iam_instance_profile.ec2.name
  subnet_id                   = var.aws_subnet_public1_id
  disable_api_termination     = var.bastion_termination

  user_data = templatefile(
    "./templates/user-data.yaml.tpl",
    {
      deploy_pubkey = data.aws_key_pair.deploy.public_key
      host_keys     = data.aws_secretsmanager_secret_version.bastion_hostkeys.secret_string
    }
  )

  root_block_device {
    encrypted   = var.bastion_volume_encrypted
    volume_size = var.bastion_volume_size
    volume_type = var.bastion_volume_type
  }
}

resource "cloudflare_record" "bastion" {
  zone_id = data.cloudflare_zone.zone.id
  name    = "bastion"
  content = aws_instance.bastion.public_ip
  type    = "A"
  proxied = false
}

Steps to Reproduce

Change user-data, notice route53 record (or cloudflare, whatever) does not update

Changing instance type also causes the same problem

Debug Output

No response

Panic Output

No response

Important Factoids

public_ip is a computed attribute. Terraform performs an action that triggers a value change but does not re-read the new attribute value and update the state. This prevents dependent resources from being updated correctly

References

https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/how-ec2-instance-stop-start-works.html

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[MS99-9]

Is anyone working on this issue? I want to try fixing it cc @justinretzolk

[nijave]

Is anyone working on this issue? I want to try fixing it cc @justinretzolk

Not me

[MS99-9]

This issue is already fixed by this commit @ewbankkit

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.