feat: add aws_vpc_ipam & aws_vpc_ipams data sources

[Volatus]

Description

This PR introduces 2 new data sources: aws_vpc_ipam and aws_vpc_ipams, following the convention of the aws_vpc_ipam_pool and aws_vpc_ipam_pools data sources.

Relations

References

Output from Acceptance Testing

❯ make testacc TESTS=TestAccEC2AwsVpcIpamDataSourceBasic PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2AwsVpcIpamDataSourceBasic'  -timeout 360m
2024/12/11 11:05:48 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2AwsVpcIpamDataSourceBasic
=== PAUSE TestAccEC2AwsVpcIpamDataSourceBasic
=== CONT  TestAccEC2AwsVpcIpamDataSourceBasic
--- PASS: TestAccEC2AwsVpcIpamDataSourceBasic (34.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        38.758s

❯ make testacc TESTS=TestAccEC2AwsVpcIpams PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2AwsVpcIpams'  -timeout 360m
2024/12/11 11:06:58 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2AwsVpcIpamsDataSourceTiered
=== PAUSE TestAccEC2AwsVpcIpamsDataSourceTiered
=== CONT  TestAccEC2AwsVpcIpamsDataSourceTiered
--- PASS: TestAccEC2AwsVpcIpamsDataSourceTiered (41.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        45.731s
...

Signed-off-by: Ismayil Mirzali [email protected]

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @Volatus 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[jar-b]

Hi @Volatus - Thanks for your submission!

As of 2023-10-20 all net-new data sources are required to use Terraform Plugin Framework. More context is available in this pinned issue and the provider contributor guide.

• Policy Change Notice: Net-new resources/data sources will be required to be based on aws-sdk-go-v2 / terraform-plugin-framework #32917
• https://hashicorp.github.io/terraform-provider-aws/terraform-plugin-development-packages/#which-plugin-version-should-i-use

Once prioritized, maintainers will convert Plugin-SDK based data sources as part of the review process, but if you'd like to do the conversion in the meantime we would greatly appreciate it!

[Volatus]

@jar-b Understood, I'll work on converting this.

[Volatus]

@jar-b I've made the necessary changes to use the plugin framework instead of SDK v2. Let me know if something needs changing.

[gflex]

@jar-b , @ewbankkit, any chance this gets any attention, please? Some of us do rely on this functionality and it's a ready PR just dusting on the shelf for over a month.

[Volatus]

@jar-b Hi, I was wondering if someone could approve the workflows, think I've fixed all the code styling issues.

[Volatus]

@jar-b Should be finally passing all checks I think.

[jar-b]

LGTM 🎉

% make testacc PKG=ec2 TESTS="TestAccVPCIPAMDataSource_|TestAccVPCIPAMsDataSource_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCIPAMDataSource_|TestAccVPCIPAMsDataSource_'  -timeout 360m -vet=off
2025/01/31 13:24:47 Initializing Terraform AWS Provider...

--- PASS: TestAccVPCIPAMsDataSource_basic (23.65s)
--- PASS: TestAccVPCIPAMsDataSource_filter (23.67s)
--- PASS: TestAccVPCIPAMDataSource_basic (23.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        30.508s

[jar-b]

Thanks for your contribution, @Volatus! 👍

[github-actions]

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!