Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Missed information about TLSv1.3 #37502

Closed
EugenKon opened this issue May 14, 2024 · 6 comments · Fixed by #37518
Closed

[Docs]: Missed information about TLSv1.3 #37502

EugenKon opened this issue May 14, 2024 · 6 comments · Fixed by #37518
Labels
documentation Introduces or discusses updates to documentation.
Milestone

Comments

@EugenKon
Copy link

EugenKon commented May 14, 2024

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudfront_distribution#origin_ssl_protocols

Description

Amazon lists TLSv1.3 as supported protocol: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/secure-connections-supported-viewer-protocols-ciphers.html
image

But in the document it is not listed:
image

  1. In this document also is not clear what is "origin" means. Is this viewer or who?

References

No response

Would you like to implement a fix?

None

@EugenKon EugenKon added the documentation Introduces or discusses updates to documentation. label May 14, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 14, 2024
@acwwat
Copy link
Contributor

acwwat commented May 14, 2024

For reference, both the API reference and AWS Go SDK v2 code seems to have only SSLv3, TLSv1, TLSv1.1, and TLSv1.2 listed.

However, the field is supposed to be for the minimum SSL/TLS protocol which is also known as the security policy described in Supported protocols and ciphers between viewers and CloudFront. For example, the TLSv1.2 security policies all support TLSv1.3 in the table on this page.

Maybe it's just to make sense of the information and document it properly to avoid confusion.

@acwwat
Copy link
Contributor

acwwat commented May 15, 2024

So there are two sub-paths along the request path that HTTPS is configurable:

  1. From the viewer (client) to CloudFront - This corresponds to the minimum_protocol_version argument in the viewer_certificate block and is as described in Supported protocols and ciphers between viewers and CloudFront.
  2. From CloudFront to a custom origin - This corresponds to the origin_ssl_protocols in the custom_origin_config block and is as described in Requiring HTTPS for communication between CloudFront and your custom origin. With Terraform, you provide not a minimum SSL/TLS version but a list of SSL/TLS versions you want to support. It looks like it TLS 1.3 is NOT supported for this communication segment.

Illustration for good measure:

image

I will update the doc to provide similar description as OriginSslProtocols which includes a link to the Developer Guide. Hopefully this clarifies the argument usage a bit.

Nonetheless it's interesting that CloudFront doesn't support TLS1.3 for all scenarios by now. If I have time, I'll open a support case to inquire as I am now curious.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.50.0 milestone May 16, 2024
@terraform-aws-provider terraform-aws-provider bot removed the needs-triage Waiting for first response or review from a maintainer. label May 16, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
2 participants