Investigate aws_emr_cluster d.Set() errors only logging instead of returning errors

[bflad]

It seems like all instances of:

	if err := d.Set("...", ...); err != nil {
		log.Printf("[ERR] Error setting ... for cluster (%s): %s", d.Id(), err)
	}

Should really be:

	if err := d.Set("...", ...); err != nil {
		return fmt.Errorf("error setting ... for cluster (%s): %s", d.Id(), err)
	}

There might be a historical reason for this current behavior though.

Terraform Version

Terraform 0.10+
All AWS provider versions

Affected Resource(s)

• aws_emr_cluster

References

https://github.com/terraform-providers/terraform-provider-aws/blob/7a6a106542fadb4d2a52883e673d3d6dbd63219e/aws/resource_aws_emr_cluster.go#L566

[bflad]

Resolved by #4488 / #6498!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!