Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for WAFv2 rule custom EvaluationWindowSec #36028

Closed
pichouk opened this issue Feb 29, 2024 · 3 comments · Fixed by #36045
Closed

[Enhancement]: Add support for WAFv2 rule custom EvaluationWindowSec #36028

pichouk opened this issue Feb 29, 2024 · 3 comments · Fixed by #36045
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Milestone

Comments

@pichouk
Copy link

pichouk commented Feb 29, 2024

Description

Yesterday AWS introduced a change in WAFv2 rules : it is now possible to choose an evaluation window for rate limit rules.
The 5 minute window is now the default for a EvaluationWindowSec parameter that can have 60, 120, 300 or 600 seconds value.

Terraform resources must be updated in order to support this new parameter.

Affected Resource(s) and/or Data Source(s)

  • aws_wafv2_web_acl
  • aws_wafv2_rule_group

Potential Terraform Configuration

# Rate limit
rule {
  name     = "RuleName"
  priority = 10

  statement {
    rate_based_statement {
      limit              = 300
      aggregate_key_type = "IP"
      evaluation_window_sec = 60
    }
  }
}

References

No response

Would you like to implement a fix?

None

@pichouk pichouk added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 29, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/wafv2 Issues and PRs that pertain to the wafv2 service. label Feb 29, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 29, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 5, 2024
@github-actions github-actions bot added this to the v5.40.0 milestone Mar 5, 2024
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
2 participants