[Enhancement]: dynamodb: add arg to set deletion protection for table replica #35359

andrei-shulaev · 2024-01-18T08:55:14Z

Description

Adds support to enable/disable deletion protection when creating/updating a dynamodb table replica.

Relations

Output from Acceptance Testing

make testacc TESTS=TestAccDynamoDBTableReplica_deletion_protection PKG=dynamodb  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableReplica_deletion_protection'  -timeout 360m
=== RUN   TestAccDynamoDBTableReplica_deletion_protection
=== PAUSE TestAccDynamoDBTableReplica_deletion_protection
=== CONT  TestAccDynamoDBTableReplica_deletion_protection
--- PASS: TestAccDynamoDBTableReplica_deletion_protection (371.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   377.910s

make testacc TESTS=TestAccDynamoDBTableReplica_basic PKG=dynamodb                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableReplica_basic'  -timeout 360m
=== RUN   TestAccDynamoDBTableReplica_basic
=== PAUSE TestAccDynamoDBTableReplica_basic
=== CONT  TestAccDynamoDBTableReplica_basic
--- PASS: TestAccDynamoDBTableReplica_basic (203.78s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   209.721s

github-actions · 2024-01-18T08:55:28Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions

Welcome @andrei-shulaev 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

andrei-shulaev · 2024-01-25T08:53:29Z

Hey @DrFaust92, could you please take a peek?

andrei-shulaev · 2024-02-15T05:46:28Z

@ewbankkit @justinretzolk
hey could you please have a look at this PR?

ankon · 2024-03-08T15:01:59Z

❤️ This would be great to have, and stop us from manually touching infrastructure!

andrei-shulaev · 2024-04-10T07:36:56Z

@ewbankkit @justinretzolk @DrFaust92

Hey it's been a while without a review, can i get your help on it please?

github-actions · 2024-05-28T11:24:10Z

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

bschaatsbergen

Hey @andrei-shulaev, thanks a lot for taking the time to raise this pull request! 👏🏼

I've left a couple drive-by comments before one of the core maintainers takes a look at this PR. Added, please make sure to update the documentation of this resource and data source with the new argument.

internal/service/dynamodb/table_replica.go

internal/service/dynamodb/table_replica_test.go

…e_replica-add-deletion-protection

bschaatsbergen · 2024-11-28T12:53:28Z

Hey @andrei-shulaev,

Thank you for your initial work on supporting the deletion_protection_enabled argument in the table replica resource. Your analysis on the propagation delay and status reporting was spot on. I’ve made a few minor adjustments, mainly cosmetic changes and tweaks to the call order. Additionally, I added a function that introduces a 1 minute and 30 second delay (just enough for propagation to complete) during the create operation. This improves the performance of subsequent read operations (refreshes), which are more frequent than re-creating the resource. The delay is applied only when the deletion_protection_enabled argument is set.

I'm now running the tests, because they take some time I'll provide an update here once they're all ran successfully.

Thanks again for your work!

bschaatsbergen

LGTM! 🚀 (had to run tests separately because of some strange context behavior)

 $ go test ./internal/service/dynamodb/... -v -count 1 -parallel 4 -run='TestAccDynamoDBTableReplica_basic' -v
2024/11/28 14:44:32 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTableReplica_basic
=== PAUSE TestAccDynamoDBTableReplica_basic
=== CONT  TestAccDynamoDBTableReplica_basic
--- PASS: TestAccDynamoDBTableReplica_basic (231.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   237.215s

 $ go test ./internal/service/dynamodb/... -v -count 1 -parallel 4 -run='TestAccDynamoDBTableReplica_disappears' -v
2024/11/28 14:53:21 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTableReplica_disappears
=== PAUSE TestAccDynamoDBTableReplica_disappears
=== CONT  TestAccDynamoDBTableReplica_disappears
--- PASS: TestAccDynamoDBTableReplica_disappears (221.18s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   226.806s

 $ go test ./internal/service/dynamodb/... -v -count 1 -parallel 4 -run='TestAccDynamoDBTableReplica_pitrDefault' -v
2024/11/28 14:52:19 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTableReplica_pitrDefault
=== PAUSE TestAccDynamoDBTableReplica_pitrDefault
=== CONT  TestAccDynamoDBTableReplica_pitrDefault
--- PASS: TestAccDynamoDBTableReplica_pitrDefault (351.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   357.359s

$ go test ./internal/service/dynamodb/... -v -count 1 -parallel 4 -run='TestAccDynamoDBTableReplica_pitrKMS' -v
2024/11/28 14:53:29 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTableReplica_pitrKMS
=== PAUSE TestAccDynamoDBTableReplica_pitrKMS
=== CONT  TestAccDynamoDBTableReplica_pitrKMS
--- PASS: TestAccDynamoDBTableReplica_pitrKMS (281.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   287.001s

 $ go test ./internal/service/dynamodb/... -v -count 1 -parallel 4 -run='TestAccDynamoDBTableReplica_pitrDefault' -v
2024/11/28 14:52:19 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTableReplica_pitrDefault
=== PAUSE TestAccDynamoDBTableReplica_pitrDefault
=== CONT  TestAccDynamoDBTableReplica_pitrDefault
--- PASS: TestAccDynamoDBTableReplica_pitrDefault (351.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   357.359s

 $ go test ./internal/service/dynamodb/... -v -count 1 -parallel 4 -run='TestAccDynamoDBTableReplica_tableClass' -v
2024/11/28 15:00:08 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTableReplica_tableClass
=== PAUSE TestAccDynamoDBTableReplica_tableClass
=== CONT  TestAccDynamoDBTableReplica_tableClass
--- PASS: TestAccDynamoDBTableReplica_tableClass (518.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   527.870s

 $ go test ./internal/service/dynamodb/... -v -count 1 -parallel 4 -run='TestAccDynamoDBTableReplica_keys' -v
2024/11/28 15:00:04 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTableReplica_keys
=== PAUSE TestAccDynamoDBTableReplica_keys
=== CONT  TestAccDynamoDBTableReplica_keys
--- PASS: TestAccDynamoDBTableReplica_keys (405.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   410.549s

 $ go test ./internal/service/dynamodb/... -v -count 1 -parallel 4 -run='TestAccDynamoDBTableReplica_deletionProtection' -v
2024/11/28 15:00:12 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBTableReplica_deletionProtection
=== PAUSE TestAccDynamoDBTableReplica_deletionProtection
=== RUN   TestAccDynamoDBTableReplica_deletionProtectionDefault
=== PAUSE TestAccDynamoDBTableReplica_deletionProtectionDefault
=== CONT  TestAccDynamoDBTableReplica_deletionProtection
=== CONT  TestAccDynamoDBTableReplica_deletionProtectionDefault
--- PASS: TestAccDynamoDBTableReplica_deletionProtectionDefault (512.04s)
--- PASS: TestAccDynamoDBTableReplica_deletionProtection (512.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   525.348s

Since I’ve made some updates to the code in this PR, I’m requesting another review from the core team. Thanks for your patience!

…otection

This is handled outside the scope of the update handler via transparent tagging.

Changes the argument to optional/computed instead. Also consolidates acceptance tests for this argument into a single test which exercies the waiters in both the create and update methods. ```console % make testacc PKG=dynamodb TESTS=TestAccDynamoDBTableReplica_deletionProtection make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.3 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableReplica_deletionProtection' -timeout 360m 2024/12/02 15:33:27 Initializing Terraform AWS Provider... --- PASS: TestAccDynamoDBTableReplica_deletionProtection (698.63s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb 703.869s ```

Adding this argument prevents the need for a second variant which functions similarly but has a built-in delay to account for delayed propagation to the table replica.

…d` default While this value does default to `false` when returned from AWS, the provider does not explicitly set a default value, so this descriptor should be omitted.

jar-b

LGTM 🎉

% make testacc PKG=dynamodb TESTS=TestAccDynamoDBTableReplica_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTableReplica_'  -timeout 360m
2024/12/03 11:14:52 Initializing Terraform AWS Provider...

--- PASS: TestAccDynamoDBTableReplica_pitr (260.06s)
=== CONT  TestAccDynamoDBTableReplica_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_emptyResourceTag (266.37s)
=== CONT  TestAccDynamoDBTableReplica_basic
--- PASS: TestAccDynamoDBTableReplica_tags_EmptyTag_OnUpdate_Replace (267.96s)
=== CONT  TestAccDynamoDBTableReplica_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_updateToProviderOnly (270.02s)
=== CONT  TestAccDynamoDBTableReplica_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_nullOverlappingResourceTag (272.81s)
=== CONT  TestAccDynamoDBTableReplica_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_nullNonOverlappingResourceTag (273.78s)
=== CONT  TestAccDynamoDBTableReplica_tags_EmptyMap
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_emptyProviderOnlyTag (275.60s)
=== CONT  TestAccDynamoDBTableReplica_tags_AddOnUpdate
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_updateToResourceOnly (276.02s)
=== CONT  TestAccDynamoDBTableReplica_tags_null
--- PASS: TestAccDynamoDBTableReplica_tags_EmptyTag_OnCreate (277.72s)
=== CONT  TestAccDynamoDBTableReplica_tags_ComputedTag_OnCreate
--- PASS: TestAccDynamoDBTableReplica_disappears (290.68s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_overlapping (378.84s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_providerOnly (380.90s)
--- PASS: TestAccDynamoDBTableReplica_pitrKMS (383.09s)
--- PASS: TestAccDynamoDBTableReplica_pitrDefault (383.75s)
--- PASS: TestAccDynamoDBTableReplica_keys (394.85s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_nonOverlapping (402.72s)
--- PASS: TestAccDynamoDBTableReplica_tags (404.44s)
--- PASS: TestAccDynamoDBTableReplica_tags_EmptyTag_OnUpdate_Add (412.77s)
--- PASS: TestAccDynamoDBTableReplica_tags_EmptyMap (235.27s)
--- PASS: TestAccDynamoDBTableReplica_tags_null (234.32s)
--- PASS: TestAccDynamoDBTableReplica_tags_ComputedTag_OnUpdate_Add (242.74s)
--- PASS: TestAccDynamoDBTableReplica_tags_AddOnUpdate (237.38s)
--- PASS: TestAccDynamoDBTableReplica_tableClass (517.17s)
--- PASS: TestAccDynamoDBTableReplica_tags_ComputedTag_OnCreate (240.49s)
--- PASS: TestAccDynamoDBTableReplica_tags_IgnoreTags_Overlap_DefaultTag (258.90s)
--- PASS: TestAccDynamoDBTableReplica_tags_IgnoreTags_Overlap_ResourceTag (255.81s)
--- PASS: TestAccDynamoDBTableReplica_tags_ComputedTag_OnUpdate_Replace (253.21s)
--- PASS: TestAccDynamoDBTableReplica_basic (260.55s)
--- PASS: TestAccDynamoDBTableReplica_deletionProtection (760.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   766.869s

jar-b · 2024-12-03T17:38:42Z

Thanks for your contribution, @andrei-shulaev! 👍

gdavison

Looks good! 🚀

--- PASS: TestAccDynamoDBTableReplica_disappears (211.09s)
--- PASS: TestAccDynamoDBTableReplica_pitr (246.23s)
--- PASS: TestAccDynamoDBTableReplica_tags_ComputedTag_OnUpdate_Replace (299.96s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_nullOverlappingResourceTag (301.63s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_emptyProviderOnlyTag (309.08s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_updateToProviderOnly (317.87s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_updateToResourceOnly (321.74s)
--- PASS: TestAccDynamoDBTableReplica_tags_IgnoreTags_Overlap_DefaultTag (322.95s)
--- PASS: TestAccDynamoDBTableReplica_tags_ComputedTag_OnUpdate_Add (323.12s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_emptyResourceTag (324.06s)
--- PASS: TestAccDynamoDBTableReplica_basic (326.05s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_nullNonOverlappingResourceTag (332.96s)
--- PASS: TestAccDynamoDBTableReplica_pitrKMS (355.25s)
--- PASS: TestAccDynamoDBTableReplica_pitrDefault (381.77s)
--- PASS: TestAccDynamoDBTableReplica_keys (426.55s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_overlapping (429.84s)
--- PASS: TestAccDynamoDBTableReplica_tags_IgnoreTags_Overlap_ResourceTag (431.03s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_nonOverlapping (432.09s)
--- PASS: TestAccDynamoDBTableReplica_tags (435.69s)
--- PASS: TestAccDynamoDBTableReplica_tags_ComputedTag_OnCreate (236.15s)
--- PASS: TestAccDynamoDBTableReplica_tags_EmptyTag_OnUpdate_Add (251.82s)
--- PASS: TestAccDynamoDBTableReplica_tags_null (230.41s)
--- PASS: TestAccDynamoDBTableReplica_tags_EmptyTag_OnCreate (345.70s)
--- PASS: TestAccDynamoDBTableReplica_tags_DefaultTags_providerOnly (313.03s)
--- PASS: TestAccDynamoDBTableReplica_tags_EmptyMap (240.15s)
--- PASS: TestAccDynamoDBTableReplica_tags_AddOnUpdate (243.73s)
--- PASS: TestAccDynamoDBTableReplica_tags_EmptyTag_OnUpdate_Replace (271.74s)
--- PASS: TestAccDynamoDBTableReplica_deletionProtection (781.69s)
--- PASS: TestAccDynamoDBTableReplica_tableClass (475.17s)

github-actions · 2024-12-04T17:15:17Z

This functionality has been released in v5.80.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2025-01-04T02:16:14Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/M Managed by automation to categorize the size of a PR. labels Jan 18, 2024

terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 18, 2024

andrei-shulaev force-pushed the f-aws_dynamodb_table_replica-add-deletion-protection branch 2 times, most recently from ad71379 to e6c9a6f Compare January 18, 2024 09:04

github-actions bot reviewed Jan 18, 2024

View reviewed changes

andrei-shulaev marked this pull request as ready for review January 18, 2024 09:12

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 18, 2024

andrei-shulaev changed the title ~~feat(dynamo): add arg to set deletion protection for table replica~~ [Enhancement]: dynamodb: add arg to set deletion protection for table replica Jan 19, 2024

aliaksandr-d approved these changes Apr 16, 2024

View reviewed changes

andrei-shulaev force-pushed the f-aws_dynamodb_table_replica-add-deletion-protection branch from a887fb1 to e6c9a6f Compare May 28, 2024 11:23

andrei-shulaev force-pushed the f-aws_dynamodb_table_replica-add-deletion-protection branch from e6c9a6f to b3bb3b6 Compare May 28, 2024 11:33

andrei-shulaev closed this May 28, 2024

andrei-shulaev force-pushed the f-aws_dynamodb_table_replica-add-deletion-protection branch from b3bb3b6 to 250de7d Compare May 28, 2024 11:43

andrei-shulaev reopened this May 31, 2024

andrei-shulaev force-pushed the f-aws_dynamodb_table_replica-add-deletion-protection branch 2 times, most recently from 6d84a7a to cce05f7 Compare May 31, 2024 10:08

bschaatsbergen reviewed May 31, 2024

View reviewed changes

feat(dynamo): add arg to set deletion protection for table replica

6f250fb

andrei-shulaev force-pushed the f-aws_dynamodb_table_replica-add-deletion-protection branch from cce05f7 to 6f250fb Compare June 3, 2024 04:25

Merge remote-tracking branch 'upstream/main' into f-aws_dynamodb_tabl…

d749190

…e_replica-add-deletion-protection

bschaatsbergen requested a review from a team as a code owner November 28, 2024 10:10

bschaatsbergen added 8 commits November 28, 2024 11:41

dynamodb: exclude tags from table replica update

f854639

dynamodb: add deletion_protection_enabled optional argument

8c6b618

dynamodb: remove redundant comments

c83d5ea

dynamodb: use acctest package

d62a3a5

dynamodb: add 1.5 min delay for attribute propagation on replicas

6307d9c

dynamodb: improve deletion protection tests

26fa285

dynamodb: improve comment

cb17dc5

dynamodb: add comment for clarity

18fdf34

dynamodb: improve variable and function name of replica propagation

4dd082f

bschaatsbergen approved these changes Nov 28, 2024 •

edited

Loading

View reviewed changes

bschaatsbergen approved these changes Nov 28, 2024

View reviewed changes

jar-b added 7 commits December 2, 2024 11:21

Merge branch 'main' into f-aws_dynamodb_table_replica-add-deletion-pr…

9fd2ef1

…otection

r/aws_dynamodb_table_replica: remove explicit update tags call

77e3c42

This is handled outside the scope of the update handler via transparent tagging.

r/aws_dynamodb_table_replica: add delay arg to waitReplicaActive

abce9b8

Adding this argument prevents the need for a second variant which functions similarly but has a built-in delay to account for delayed propagation to the table replica.

r/aws_dynamodb_table_replica(doc): remove `deletion_protection_enable…

4ff8557

…d` default While this value does default to `false` when returned from AWS, the provider does not explicitly set a default value, so this descriptor should be omitted.

r/aws_dynamodb_table_replica(test): cleanup tags test configs

0fbb5e3

r/aws_dynamodb_table_replica(test): fix _basic test checks

b308340

jar-b previously approved these changes Dec 3, 2024

View reviewed changes

chore: make fix-constants

c0cc632

jar-b dismissed their stale review via c0cc632 December 3, 2024 17:58

gdavison approved these changes Dec 3, 2024

View reviewed changes

jar-b merged commit 0dfa71d into hashicorp:main Dec 3, 2024
41 checks passed

github-actions bot added this to the v5.80.0 milestone Dec 3, 2024

hallm4 mentioned this pull request Dec 16, 2024

[Bug]: When attempting to create a dynamodb_table with multiple regions, it hangs and never completes #40531

Open

github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement]: dynamodb: add arg to set deletion protection for table replica #35359

[Enhancement]: dynamodb: add arg to set deletion protection for table replica #35359

andrei-shulaev commented Jan 18, 2024 •

edited

Loading

github-actions bot commented Jan 18, 2024

github-actions bot left a comment

andrei-shulaev commented Jan 25, 2024

andrei-shulaev commented Feb 15, 2024

ankon commented Mar 8, 2024

andrei-shulaev commented Apr 10, 2024

github-actions bot commented May 28, 2024

bschaatsbergen left a comment •

edited

Loading

bschaatsbergen commented Nov 28, 2024

bschaatsbergen left a comment •

edited

Loading

jar-b left a comment

jar-b commented Dec 3, 2024

gdavison left a comment

github-actions bot commented Dec 4, 2024

github-actions bot commented Jan 4, 2025

[Enhancement]: dynamodb: add arg to set deletion protection for table replica #35359

[Enhancement]: dynamodb: add arg to set deletion protection for table replica #35359

Conversation

andrei-shulaev commented Jan 18, 2024 • edited Loading

Description

Relations

Output from Acceptance Testing

github-actions bot commented Jan 18, 2024

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

andrei-shulaev commented Jan 25, 2024

andrei-shulaev commented Feb 15, 2024

ankon commented Mar 8, 2024

andrei-shulaev commented Apr 10, 2024

github-actions bot commented May 28, 2024

bschaatsbergen left a comment • edited Loading

Choose a reason for hiding this comment

bschaatsbergen commented Nov 28, 2024

bschaatsbergen left a comment • edited Loading

Choose a reason for hiding this comment

jar-b left a comment

Choose a reason for hiding this comment

jar-b commented Dec 3, 2024

gdavison left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 4, 2024

github-actions bot commented Jan 4, 2025

andrei-shulaev commented Jan 18, 2024 •

edited

Loading

bschaatsbergen left a comment •

edited

Loading

bschaatsbergen left a comment •

edited

Loading