Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Quicksight analysis: raise limit for maximum allowed visuals per sheet from 30 to 50 #32855

Closed
denvazh opened this issue Aug 4, 2023 · 3 comments · Fixed by #32856
Closed
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Milestone

Comments

@denvazh
Copy link
Contributor

denvazh commented Aug 4, 2023

Terraform Core Version

1.5.2

AWS Provider Version

5.11.0

Affected Resource(s)

aws_quicksight_analysis

Expected Behavior

Should be able to create, update, import analysis with number of visuals per sheet between 1 and 50.

Actual Behavior

Error is raised when one tries to create or import analysis where number of visuals blocks in given sheet is more than 30 but less than 50.

│ Error: Too many visuals blocks
│
│   on import.tf line 12191, in resource "aws_quicksight_analysis" "sample-client-report":
│ 12191:       visuals {
│
│ No more than 30 "visuals" blocks are allowed

Relevant Error/Panic Output Snippet

│ Error: Too many visuals blocks
│
│   on import.tf line 12191, in resource "aws_quicksight_analysis" "sample-client-report":
│ 12191:       visuals {
│
│ No more than 30 "visuals" blocks are allowed

Terraform Configuration Files

resource "aws_quicksight_analysis" "analysis-with-31-visuals" {
  analysis_id    = "ID"
  name           = "NAME"
  aws_account_id = data.aws_caller_identity.current.account_id
  definition {
    data_set_identifiers_declarations {
      data_set_arn = "ARN"
      identifier   = "IDENTIFIER"
    }
    sheets {
      title    = "31 Visuals"
      sheet_id = "SHEET"

      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom1"
            }
          }
          visual_id = "CUSTOM1"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom2"
            }
          }
          visual_id = "CUSTOM2"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom3"
            }
          }
          visual_id = "CUSTOM3"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom4"
            }
          }
          visual_id = "CUSTOM4"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom5"
            }
          }
          visual_id = "CUSTOM5"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom6"
            }
          }
          visual_id = "CUSTOM6"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom7"
            }
          }
          visual_id = "CUSTOM7"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom8"
            }
          }
          visual_id = "CUSTOM8"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom9"
            }
          }
          visual_id = "CUSTOM9"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom10"
            }
          }
          visual_id = "CUSTOM10"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom11"
            }
          }
          visual_id = "CUSTOM11"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom12"
            }
          }
          visual_id = "CUSTOM12"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom13"
            }
          }
          visual_id = "CUSTOM13"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom14"
            }
          }
          visual_id = "CUSTOM14"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom15"
            }
          }
          visual_id = "CUSTOM15"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom16"
            }
          }
          visual_id = "CUSTOM16"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom17"
            }
          }
          visual_id = "CUSTOM17"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom18"
            }
          }
          visual_id = "CUSTOM18"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom19"
            }
          }
          visual_id = "CUSTOM19"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom20"
            }
          }
          visual_id = "CUSTOM20"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom21"
            }
          }
          visual_id = "CUSTOM21"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom22"
            }
          }
          visual_id = "CUSTOM22"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom23"
            }
          }
          visual_id = "CUSTOM23"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom24"
            }
          }
          visual_id = "CUSTOM24"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom25"
            }
          }
          visual_id = "CUSTOM25"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom26"
            }
          }
          visual_id = "CUSTOM26"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom27"
            }
          }
          visual_id = "CUSTOM27"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom28"
            }
          }
          visual_id = "CUSTOM28"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom29"
            }
          }
          visual_id = "CUSTOM29"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom30"
            }
          }
          visual_id = "CUSTOM30"
        }
      }
      visuals {
        custom_content_visual {
          data_set_identifier = "1"
          title {
            format_text {
              plain_text = "Custom31"
            }
          }
          visual_id = "CUSTOM31"
        }
      }
    }
  }
}

Steps to Reproduce

Run plan or apply for the Terraform code above.

Debug Output

It seems limit is set in internal/service/quicksight/schema/visual.go:25. visualsSchema() should return schema with MaxItems set to 50

Panic Output

No response

Important Factoids

No response

References

Limit of 50 is mentioned in the official API documentation:

Hard limit increase from 30 to 50 confirmation by AWS support:

Would you like to implement a fix?

Yes

@denvazh denvazh added the bug Addresses a defect in current functionality. label Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/quicksight Issues and PRs that pertain to the quicksight service. needs-triage Waiting for first response or review from a maintainer. labels Aug 4, 2023
@denvazh denvazh changed the title [Bug]: Raise limit for maximum allowed visuals per sheet Quicksight analysis from 30 to 50 [Bug]: Raise limit for maximum allowed visuals per sheet in Quicksight analysis from 30 to 50 Aug 4, 2023
@denvazh denvazh changed the title [Bug]: Raise limit for maximum allowed visuals per sheet in Quicksight analysis from 30 to 50 [Bug]: Quicksight analysis: raise limit for maximum allowed visuals per sheet from 30 to 50 Aug 4, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 7, 2023
@github-actions github-actions bot added this to the v5.13.0 milestone Aug 11, 2023
@github-actions
Copy link

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
2 participants