Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurora I/O-Optimized (storage_type) #31336

Merged
merged 14 commits into from
May 11, 2023

Conversation

AdamTylerLynch
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch commented May 11, 2023

Description

Amazon Aurora I/O-Optimized, a new configuration for Amazon Aurora that provides price predictability for all applications.

Relations

Relates #30287

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccRDSCluster_basic\|TestAccRDSCluster_storageTypeAurora\|TestAccRDSCluster_storageTypeIo1' PKG=rds ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 5  -run=TestAccRDSCluster_basic\|TestAccRDSCluster_storageTypeAurora\|TestAccRDSCluster_storageTypeIo1 -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_storageTypeIo1
=== PAUSE TestAccRDSCluster_storageTypeIo1
=== RUN   TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== PAUSE TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1
=== RUN   TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== PAUSE TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
=== RUN   TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== PAUSE TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1
=== CONT  TestAccRDSCluster_storageTypeAuroraReturnsBlank
=== CONT  TestAccRDSCluster_storageTypeIo1
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
--- PASS: TestAccRDSCluster_basic (166.94s)
=== CONT  TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
--- PASS: TestAccRDSCluster_storageTypeAuroraReturnsBlank (185.10s)
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1 (185.28s)
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora (274.06s)
--- PASS: TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1 (285.42s)
--- PASS: TestAccRDSCluster_storageTypeIo1 (2105.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2111.159s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. partner Contribution from a partner. needs-triage Waiting for first response or review from a maintainer. labels May 11, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 11, 2023
@jar-b jar-b self-assigned this May 11, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTARGS='-run=TestAccRDSCluster_basic\|TestAccRDSCluster_storageTypeAurora\|TestAccRDSCluster_storageTypeIo1' PKG=rds                                                                [280/295]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCluster_basic\|TestAccRDSCluster_storageTypeAurora\|TestAccRDSCluster_storageTypeIo1 -timeout 180m

--- PASS: TestAccRDSCluster_basic (128.62s)
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1 (166.69s)
--- PASS: TestAccRDSCluster_storageTypeAuroraReturnsBlank (185.68s)
--- PASS: TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1 (226.82s)
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora (248.25s)
--- PASS: TestAccRDSCluster_storageTypeIo1 (2236.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        2239.552s
$ make testacc PKG=rds TESTS=TestAccRDSCluster_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_'  -timeout 180m

--- PASS: TestAccRDSCluster_iamAuth (174.79s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_kmsKeyID
--- PASS: TestAccRDSCluster_deletionProtection (214.79s)
=== CONT  TestAccRDSCluster_kmsKey
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal
--- PASS: TestAccRDSCluster_basic (217.67s)
--- PASS: TestAccRDSCluster_encrypted (235.42s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineVersion_different
--- PASS: TestAccRDSCluster_backupsUpdate (255.23s)
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1
--- PASS: TestAccRDSCluster_password (256.72s)                                                                                                                                                         [70/295]
=== CONT  TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora
--- PASS: TestAccRDSCluster_networkType (279.09s)
=== CONT  TestAccRDSCluster_allocatedStorage
--- PASS: TestAccRDSCluster_copyTagsToSnapshot (298.69s)
=== CONT  TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1
--- PASS: TestAccRDSCluster_SnapshotIdentifier_tags (375.23s)
=== CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
--- PASS: TestAccRDSCluster_kmsKey (180.85s)
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
=== CONT  TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1 (146.36s)
--- PASS: TestAccRDSCluster_enableHTTPEndpoint (408.76s)
=== CONT  TestAccRDSCluster_missingUserNameCausesError
--- PASS: TestAccRDSCluster_missingUserNameCausesError (5.11s)
=== CONT  TestAccRDSCluster_takeFinalSnapshot
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredBackupWindow (435.86s)
=== CONT  TestAccRDSCluster_dbSubnetGroupName
=== CONT  TestAccRDSCluster_pointInTimeRestore
--- PASS: TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags (438.24s)
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterUsername (476.00s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding
--- PASS: TestAccRDSCluster_storageTypeAuroraIopt1UpdateAurora (226.67s)
=== CONT  TestAccRDSCluster_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSCluster_SnapshotIdentifier_preferredMaintenanceWindow (497.68s)
=== CONT  TestAccRDSCluster_snapshotIdentifier
--- PASS: TestAccRDSCluster_SnapshotIdentifier_vpcSecurityGroupIDs (499.42s)
=== CONT  TestAccRDSCluster_Scaling_defaultMinCapacity
--- PASS: TestAccRDSCluster_SnapshotIdentifier_encryptedRestore (537.76s)
=== CONT  TestAccRDSCluster_serverlessV2ScalingConfiguration
--- PASS: TestAccRDSCluster_storageTypeAuroraUpdateAuroraIopt1 (242.52s)
=== CONT  TestAccRDSCluster_scaling
--- PASS: TestAccRDSCluster_SnapshotIdentifier_kmsKeyID (385.19s)
=== CONT  TestAccRDSCluster_port
--- PASS: TestAccRDSCluster_takeFinalSnapshot (226.05s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSCluster_dbSubnetGroupName (204.18s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSCluster_EnabledCloudWatchLogsExports_mySQL (244.90s)
=== CONT  TestAccRDSCluster_ManagedMasterPassword_managed
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_different (428.45s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgrade
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineVersion_equal (449.00s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters
--- PASS: TestAccRDSCluster_SnapshotIdentifier_masterPassword (739.87s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm
--- PASS: TestAccRDSCluster_port (183.98s)
=== CONT  TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately
--- PASS: TestAccRDSCluster_serverlessV2ScalingConfiguration (211.92s)
=== CONT  TestAccRDSCluster_backtrackWindow
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managedSpecificKMSKey (144.17s)
=== CONT  TestAccRDSCluster_dbClusterInstanceClass
--- PASS: TestAccRDSCluster_Scaling_defaultMinCapacity (297.15s)
=== CONT  TestAccRDSCluster_identifierGenerated
--- PASS: TestAccRDSCluster_ManagedMasterPassword_managed (157.77s)
=== CONT  TestAccRDSCluster_identifierPrefix
--- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (430.50s)
--- PASS: TestAccRDSCluster_tags (164.55s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add
--- PASS: TestAccRDSCluster_SnapshotIdentifier_deletionProtection (487.65s)
=== CONT  TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global
--- PASS: TestAccRDSCluster_identifierPrefix (185.56s)
=== CONT  TestAccRDSCluster_storageTypeIo1
--- PASS: TestAccRDSCluster_disappears (163.25s)
=== CONT  TestAccRDSCluster_storageTypeAuroraReturnsBlank
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_remove (178.32s)
=== CONT  TestAccRDSCluster_availabilityZones
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_provisioned (158.87s)
=== CONT  TestAccRDSCluster_minorVersion
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_update (162.53s)
=== CONT  TestAccRDSCluster_engineVersion
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineModeGlobal_add (162.77s)
=== CONT  TestAccRDSCluster_engineMode
--- PASS: TestAccRDSCluster_GlobalClusterIdentifierEngineMode_global (189.77s)
=== CONT  TestAccRDSCluster_updateIAMRoles
--- PASS: TestAccRDSCluster_availabilityZones (146.31s)
=== CONT  TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned
--- PASS: TestAccRDSCluster_storageTypeAuroraReturnsBlank (207.19s)
--- PASS: TestAccRDSCluster_updateIAMRoles (217.95s)
--- PASS: TestAccRDSCluster_SnapshotIdentifierEngineMode_provisioned (406.71s)
--- PASS: TestAccRDSCluster_engineVersion (510.12s)
--- PASS: TestAccRDSCluster_engineMode (491.06s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately (1040.60s)
=== NAME  TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql
    cluster_test.go:972: Step 2/2 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # aws_rds_cluster.test will be updated in-place
          ~ resource "aws_rds_cluster" "test" {
              ~ enabled_cloudwatch_logs_exports     = [
                  + "upgrade",
                    # (1 unchanged element hidden)
                ]
                id                                  = "tf-acc-test-6431187972493500977"
                tags                                = {}
                # (38 unchanged attributes hidden)
            }

        Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (2202.95s)
--- PASS: TestAccRDSCluster_iops (2240.34s)
--- PASS: TestAccRDSCluster_minorVersion (1206.54s)
--- PASS: TestAccRDSCluster_allocatedStorage (2067.31s)
--- FAIL: TestAccRDSCluster_EnabledCloudWatchLogsExports_postgresql (2119.62s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (1965.23s)
--- PASS: TestAccRDSCluster_engineVersionWithPrimaryInstance (1722.46s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (2429.52s)
--- PASS: TestAccRDSCluster_dbClusterInstanceClass (2321.64s)
--- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (2375.43s)
--- PASS: TestAccRDSCluster_storageTypeIo1 (2383.67s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_primarySecondaryClusters (2742.25s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_replicationSourceIdentifier (2835.76s)
--- PASS: TestAccRDSCluster_GlobalClusterIdentifier_secondaryClustersWriteForwarding (3574.28s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/rds        4054.192s

Failing test case is unrelated to this change.

@jar-b jar-b merged commit 62ebec3 into hashicorp:main May 11, 2023
@github-actions github-actions bot added this to the v4.67.0 milestone May 11, 2023
@github-actions
Copy link

This functionality has been released in v4.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants