Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configservice/remediation_configuration: parameters TypeSet -> TypeList #31315

Merged
merged 2 commits into from
May 11, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented May 10, 2023

Description

Relations

Closes #31319

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccConfigService_serial/RemediationConfiguration' PKG=configservice

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/RemediationConfiguration -timeout 180m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/RemediationConfiguration
=== RUN   TestAccConfigService_serial/RemediationConfiguration/disappears
=== RUN   TestAccConfigService_serial/RemediationConfiguration/migrateParameters
=== RUN   TestAccConfigService_serial/RemediationConfiguration/recreates
=== RUN   TestAccConfigService_serial/RemediationConfiguration/updates
=== RUN   TestAccConfigService_serial/RemediationConfiguration/values
=== RUN   TestAccConfigService_serial/RemediationConfiguration/basic
=== RUN   TestAccConfigService_serial/RemediationConfiguration/basicBackward
--- PASS: TestAccConfigService_serial (609.31s)
    --- PASS: TestAccConfigService_serial/RemediationConfiguration (609.31s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/disappears (78.54s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/migrateParameters (104.69s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/recreates (92.84s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/updates (89.80s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/values (81.52s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basic (81.20s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basicBackward (80.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	612.605s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@johnsonaj johnsonaj marked this pull request as ready for review May 10, 2023 18:52
@github-actions github-actions bot added service/configservice Issues and PRs that pertain to the configservice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels May 10, 2023
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label May 10, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@johnsonaj johnsonaj merged commit 5ebb37c into main May 11, 2023
@johnsonaj johnsonaj deleted the b-aws_config_remediation_configuration-parameters branch May 11, 2023 13:18
@github-actions github-actions bot added this to the v4.67.0 milestone May 11, 2023
github-actions bot pushed a commit that referenced this pull request May 11, 2023
@github-actions
Copy link

This functionality has been released in v4.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@abvm659
Copy link

abvm659 commented May 16, 2023

Hi, this change seemed to broke the resource, it is now incorrectly processing static_value is my quick guess, e.g.:

│ DefaultInstanceProfileArn: {
│ StaticValue: {
│ Values: ["arn:aws:iam::....:instance-profile/services/....."]
│ }
│ }

Shouldn't be list but single value .. it is now failing on:

InvalidParameterValueException: There were invalid RemediationParameterValues for configurations for AWS Config Rules

For previous provider 4.66.1 it works fine.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/configservice Issues and PRs that pertain to the configservice service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: aws_config_remediation_configuration error when setting parameter in state
3 participants