[Bug]: Lake Formation Resource Permission parameters need to be Lexical order

[whatnick]

Terraform Core Version

1.3.6

AWS Provider Version

4.64.0

Affected Resource(s)

• aws_lakeformation_permissions

Expected Behavior

The following code block should not lead to deletion/creation of resources if unchanged.

resource "aws_lakeformation_permissions" "lf_read" {
    permissions = ["SELECT", "DESCRIBE"]
    for_each = data.aws_iam_role.some_roles
    principal = each.value.arn
    table {
        database_name = var.glue_database
        wildcard = true
    }
}

Actual Behavior

The above code block leads to deletion and creation of the lake formation permission on multiple runs due to internal/implicit reordering in the provider to lexical order.

Changing the source in Terraform for permissions to be lexical order stops this unexpected behaviour.

resource "aws_lakeformation_permissions" "lf_read" {
    permissions = ["DESCRIBE", "SELECT"]
    for_each = data.aws_iam_role.some_roles
    principal = each.value.arn
    table {
        database_name = var.glue_database
        wildcard = true
    }
}

Relevant Error/Panic Output Snippet

N/A

Terraform Configuration Files

N/A

Steps to Reproduce

N/A

Debug Output

N/A

Panic Output

N/A

Important Factoids

The documentation hints towards implicit lexical ordering. This helped with troubleshooting this issue. Happy to document this in the provider explicitly.

Valid values may include ALL, ALTER, ASSOCIATE, CREATE_DATABASE, CREATE_TABLE, DATA_LOCATION_ACCESS, DELETE, DESCRIBE, DROP, INSERT, and SELECT

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lakeformation_permissions

Would you like to implement a fix?

Yes

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[lawliet89]

Seeing the same issue.

It's even worse in HCP Terraform with the condensed diff which made me scratch my head

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.