Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'context' field to EC2 spot fleet request #30918

Merged
merged 5 commits into from
May 3, 2023

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Apr 24, 2023

Description

Add the context field to aws_spot_fleet_request.

Relations

References

Output from Acceptance Testing

$ make testacc PKG=ec2 TESTS=TestAccEC2SpotFleetRequest_context
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SpotFleetRequest_context'  -timeout 180m
=== RUN   TestAccEC2SpotFleetRequest_context
=== PAUSE TestAccEC2SpotFleetRequest_context
=== CONT  TestAccEC2SpotFleetRequest_context
--- PASS: TestAccEC2SpotFleetRequest_context (22.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        22.375s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. partner Contribution from a partner. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. labels Apr 24, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 24, 2023
@cjerad cjerad changed the title [WIP] Add 'context' field to EC2 spot fleet request Add 'context' field to EC2 spot fleet request Apr 24, 2023
@cjerad cjerad marked this pull request as ready for review April 24, 2023 19:57
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 24, 2023
@gdavison gdavison self-assigned this Apr 25, 2023
@gdavison
Copy link
Contributor

Thanks for submitting this PR, @cjerad. Since this is a reserved field, it typically shouldn't be configured. Is there an undocumented use for the field?

@gdavison gdavison added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 25, 2023
@cjerad
Copy link
Contributor Author

cjerad commented Apr 28, 2023

Hi @gdavison, some customers use the field in special cases, and adding it will align the TF resource with the CloudFormation resource.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 28, 2023
@AdamTylerLynch
Copy link
Collaborator

LGTM 🚀

Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👾

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@gdavison gdavison merged commit 1bc43a1 into hashicorp:main May 3, 2023
@github-actions github-actions bot added this to the v4.66.0 milestone May 3, 2023
@cjerad cjerad deleted the f-aws_spot_fleet_request-context branch May 4, 2023 16:21
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants