Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit for reference_sets in aws_networkfirewall_rule_group #30759

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Add limit for reference_sets in aws_networkfirewall_rule_group #30759

merged 2 commits into from
Apr 26, 2023

Conversation

HorizonNet
Copy link
Contributor

Description

Add a limit of 5 reference_sets within a rule_group of aws_networkfirewall_rule_group.

Relations

Closes #28464

References

https://docs.aws.amazon.com/network-firewall/latest/developerguide/rule-groups-ip-set-references.html#rule-groups-ip-set-reference-limits

Output from Acceptance Testing

$ make testacc TESTS='TestAccNetworkFirewallRuleGroup_' PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallRuleGroup_'  -timeout 180m
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rules
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rules
=== RUN   TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== PAUSE TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== RUN   TestAccNetworkFirewallRuleGroup_updateRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRules
=== RUN   TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== PAUSE TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_tags
=== PAUSE TestAccNetworkFirewallRuleGroup_tags
=== RUN   TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== PAUSE TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== RUN   TestAccNetworkFirewallRuleGroup_disappears
=== PAUSE TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rules
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== CONT  TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== CONT  TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== CONT  TestAccNetworkFirewallRuleGroup_updateRules
=== CONT  TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== CONT  TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== CONT  TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== CONT  TestAccNetworkFirewallRuleGroup_tags
--- PASS: TestAccNetworkFirewallRuleGroup_tags (143.51s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statelessRule (147.35s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statefulRule (172.19s)
--- PASS: TestAccNetworkFirewallRuleGroup_statefulRuleOptions (174.53s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rules (180.45s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList (182.96s)
--- PASS: TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction (185.00s)
--- PASS: TestAccNetworkFirewallRuleGroup_disappears (187.65s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_referenceSets (193.19s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRules (206.09s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatelessRule (208.87s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_header (215.21s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets (215.60s)
--- PASS: TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (218.87s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRulesSourceList (219.18s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRule (221.79s)
--- PASS: TestAccNetworkFirewallRuleGroup_encryptionConfiguration (247.00s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules (249.68s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_action (250.31s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions (339.56s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    343.222s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Apr 16, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 25, 2023
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @HorizonNet for the contribution.

$ make testacc TESTS='TestAccNetworkFirewallRuleGroup_' PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallRuleGroup_'  -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.44.243
go: downloading github.com/hashicorp/terraform-json v0.16.0
go: downloading gopkg.in/dnaeon/go-vcr.v3 v3.1.2
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rules
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rules
=== RUN   TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== PAUSE TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== RUN   TestAccNetworkFirewallRuleGroup_updateRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRules
=== RUN   TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== PAUSE TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_tags
=== PAUSE TestAccNetworkFirewallRuleGroup_tags
=== RUN   TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== PAUSE TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== RUN   TestAccNetworkFirewallRuleGroup_disappears
=== PAUSE TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rules
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== CONT  TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== CONT  TestAccNetworkFirewallRuleGroup_tags
=== CONT  TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== CONT  TestAccNetworkFirewallRuleGroup_updateRules
=== CONT  TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== CONT  TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== CONT  TestAccNetworkFirewallRuleGroup_disappears
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statefulRule (133.83s)
--- PASS: TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction (155.30s)
--- PASS: TestAccNetworkFirewallRuleGroup_tags (155.75s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRulesSourceList (160.31s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRules (161.09s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rules (161.91s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statelessRule (162.57s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatelessRule (162.69s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList (162.82s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRule (164.07s)
--- PASS: TestAccNetworkFirewallRuleGroup_disappears (164.90s)
--- PASS: TestAccNetworkFirewallRuleGroup_statefulRuleOptions (167.17s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_referenceSets (167.63s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets (171.43s)
--- PASS: TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (186.72s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules (195.08s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_header (195.09s)
--- PASS: TestAccNetworkFirewallRuleGroup_encryptionConfiguration (195.52s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_action (197.76s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions (307.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	311.118s

@breathingdust
Copy link
Member

LGTM @HorizonNet 🚀 Thanks for the contribution!

$ make testacc TESTS='TestAccNetworkFirewallRuleGroup_' PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallRuleGroup_'  -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.44.243
go: downloading github.com/hashicorp/terraform-json v0.16.0
go: downloading gopkg.in/dnaeon/go-vcr.v3 v3.1.2
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_Basic_rules
=== PAUSE TestAccNetworkFirewallRuleGroup_Basic_rules
=== RUN   TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== RUN   TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== PAUSE TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== RUN   TestAccNetworkFirewallRuleGroup_updateRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRules
=== RUN   TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== PAUSE TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== RUN   TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== PAUSE TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== RUN   TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== PAUSE TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== RUN   TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== PAUSE TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== RUN   TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== PAUSE TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== RUN   TestAccNetworkFirewallRuleGroup_tags
=== PAUSE TestAccNetworkFirewallRuleGroup_tags
=== RUN   TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== PAUSE TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== RUN   TestAccNetworkFirewallRuleGroup_disappears
=== PAUSE TestAccNetworkFirewallRuleGroup_disappears
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_updateRulesSourceList
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_rules
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_header
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_statefulRuleOptions
=== CONT  TestAccNetworkFirewallRuleGroup_encryptionConfiguration
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRule
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statefulRule
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_statelessRule
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets
=== CONT  TestAccNetworkFirewallRuleGroup_Basic_referenceSets
=== CONT  TestAccNetworkFirewallRuleGroup_tags
=== CONT  TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction
=== CONT  TestAccNetworkFirewallRuleGroup_updateRules
=== CONT  TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules
=== CONT  TestAccNetworkFirewallRuleGroup_StatefulRule_action
=== CONT  TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions
=== CONT  TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables
=== CONT  TestAccNetworkFirewallRuleGroup_disappears
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statefulRule (133.83s)
--- PASS: TestAccNetworkFirewallRuleGroup_statelessRuleWithCustomAction (155.30s)
--- PASS: TestAccNetworkFirewallRuleGroup_tags (155.75s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRulesSourceList (160.31s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateRules (161.09s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rules (161.91s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_statelessRule (162.57s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatelessRule (162.69s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_rulesSourceList (162.82s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRule (164.07s)
--- PASS: TestAccNetworkFirewallRuleGroup_disappears (164.90s)
--- PASS: TestAccNetworkFirewallRuleGroup_statefulRuleOptions (167.17s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_referenceSets (167.63s)
--- PASS: TestAccNetworkFirewallRuleGroup_Basic_updateReferenceSets (171.43s)
--- PASS: TestAccNetworkFirewallRuleGroup_rulesSourceAndRuleVariables (186.72s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateMultipleStatefulRules (195.08s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_header (195.09s)
--- PASS: TestAccNetworkFirewallRuleGroup_encryptionConfiguration (195.52s)
--- PASS: TestAccNetworkFirewallRuleGroup_StatefulRule_action (197.76s)
--- PASS: TestAccNetworkFirewallRuleGroup_updateStatefulRuleOptions (307.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	311.118s

@breathingdust breathingdust merged commit 8685ce1 into hashicorp:main Apr 26, 2023
@github-actions github-actions bot added this to the v4.65.0 milestone Apr 26, 2023
@HorizonNet HorizonNet deleted the f-issue-28464 branch April 26, 2023 16:54
@github-actions
Copy link

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.65.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_networkfirewall_rule_group Reference Sets to be limited to 5
3 participants
@HorizonNet @breathingdust @justinretzolk