Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate chime sdk voice streaming with media insights configuration #30713

Merged
merged 4 commits into from
Apr 27, 2023
Merged

integrate chime sdk voice streaming with media insights configuration #30713

merged 4 commits into from
Apr 27, 2023

Conversation

lognoel
Copy link
Contributor

@lognoel lognoel commented Apr 13, 2023

Description

  • updated voice_connector_streaming.go to use the chimesdkvoice namespace instead of the chime namespace. New changes to PutVoiceConnectorStreaming api (reference) are only available in the new namespace, but are backward compatible.
  • integrated aws_chime_voice_connector_streaming with aws_chimesdkmediapipelines_media_insights_pipeline_configuration introduced by Add media insights pipeline configuration resource #30603

Relations

Relates #30300

References

Output from Acceptance Testing

make testacc PKG=chime TESTS=TestAccChimeVoiceConnectorStreaming
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20 -run='TestAccChimeVoiceConnectorStreaming'  -timeout 180m
=== RUN   TestAccChimeVoiceConnectorStreaming_basic
=== PAUSE TestAccChimeVoiceConnectorStreaming_basic
=== RUN   TestAccChimeVoiceConnectorStreaming_disappears
=== PAUSE TestAccChimeVoiceConnectorStreaming_disappears
=== RUN   TestAccChimeVoiceConnectorStreaming_update
=== PAUSE TestAccChimeVoiceConnectorStreaming_update
=== CONT  TestAccChimeVoiceConnectorStreaming_basic
=== CONT  TestAccChimeVoiceConnectorStreaming_update
=== CONT  TestAccChimeVoiceConnectorStreaming_disappears
--- PASS: TestAccChimeVoiceConnectorStreaming_disappears (17.43s)
--- PASS: TestAccChimeVoiceConnectorStreaming_basic (20.14s)
--- PASS: TestAccChimeVoiceConnectorStreaming_update (63.50s)
PASS

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/chime Issues and PRs that pertain to the chime service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Apr 13, 2023
@lognoel lognoel marked this pull request as ready for review April 13, 2023 20:20
@justinretzolk justinretzolk added new-service Introduces a new service. enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 25, 2023
@jar-b jar-b self-assigned this Apr 27, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

make testacc PKG=chime TESTS=TestAccChimeVoiceConnectorStreaming_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20 -run='TestAccChimeVoiceConnectorStreaming_'  -timeout 180m
=== RUN   TestAccChimeVoiceConnectorStreaming_basic
=== PAUSE TestAccChimeVoiceConnectorStreaming_basic
=== RUN   TestAccChimeVoiceConnectorStreaming_disappears
=== PAUSE TestAccChimeVoiceConnectorStreaming_disappears
=== RUN   TestAccChimeVoiceConnectorStreaming_update
=== PAUSE TestAccChimeVoiceConnectorStreaming_update
=== CONT  TestAccChimeVoiceConnectorStreaming_basic
=== CONT  TestAccChimeVoiceConnectorStreaming_update
=== CONT  TestAccChimeVoiceConnectorStreaming_disappears
--- PASS: TestAccChimeVoiceConnectorStreaming_disappears (13.29s)
--- PASS: TestAccChimeVoiceConnectorStreaming_basic (15.63s)
--- PASS: TestAccChimeVoiceConnectorStreaming_update (59.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chime      62.492s

@jar-b jar-b merged commit eb78867 into hashicorp:main Apr 27, 2023
@jar-b
Copy link
Member

jar-b commented Apr 27, 2023

Thanks for your contribution, @lognoel! 👍

@github-actions github-actions bot added this to the v4.65.0 milestone Apr 27, 2023
@lognoel lognoel deleted the f-chime-sdk-voice-streaming branch April 27, 2023 17:32
@github-actions
Copy link

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-service Introduces a new service. partner Contribution from a partner. service/chime Issues and PRs that pertain to the chime service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants