-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_dynamodb_table_item: Correctly handle List and Map attribute JSON values #30712
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDynamoDBTableItem' PKG=dynamodb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 3 -run=TestAccDynamoDBTableItem -timeout 180m
=== RUN TestAccDynamoDBTableItemDataSource_basic
=== PAUSE TestAccDynamoDBTableItemDataSource_basic
=== RUN TestAccDynamoDBTableItemDataSource_projectionExpression
=== PAUSE TestAccDynamoDBTableItemDataSource_projectionExpression
=== RUN TestAccDynamoDBTableItemDataSource_expressionAttributeNames
=== PAUSE TestAccDynamoDBTableItemDataSource_expressionAttributeNames
=== RUN TestAccDynamoDBTableItem_basic
=== PAUSE TestAccDynamoDBTableItem_basic
=== RUN TestAccDynamoDBTableItem_rangeKey
=== PAUSE TestAccDynamoDBTableItem_rangeKey
=== RUN TestAccDynamoDBTableItem_withMultipleItems
=== PAUSE TestAccDynamoDBTableItem_withMultipleItems
=== RUN TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey
=== PAUSE TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey
=== RUN TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey
=== PAUSE TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey
=== RUN TestAccDynamoDBTableItem_wonkyItems
=== PAUSE TestAccDynamoDBTableItem_wonkyItems
=== RUN TestAccDynamoDBTableItem_update
=== PAUSE TestAccDynamoDBTableItem_update
=== RUN TestAccDynamoDBTableItem_updateWithRangeKey
=== PAUSE TestAccDynamoDBTableItem_updateWithRangeKey
=== RUN TestAccDynamoDBTableItem_disappears
=== PAUSE TestAccDynamoDBTableItem_disappears
=== RUN TestAccDynamoDBTableItem_mapOutOfBandUpdate
=== PAUSE TestAccDynamoDBTableItem_mapOutOfBandUpdate
=== CONT TestAccDynamoDBTableItemDataSource_basic
=== CONT TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey
=== CONT TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey
--- PASS: TestAccDynamoDBTableItem_withDuplicateItemsSameRangeKey (30.54s)
=== CONT TestAccDynamoDBTableItem_withMultipleItems
--- PASS: TestAccDynamoDBTableItem_withDuplicateItemsDifferentRangeKey (48.61s)
=== CONT TestAccDynamoDBTableItem_rangeKey
--- PASS: TestAccDynamoDBTableItemDataSource_basic (48.86s)
=== CONT TestAccDynamoDBTableItem_basic
--- PASS: TestAccDynamoDBTableItem_withMultipleItems (45.29s)
=== CONT TestAccDynamoDBTableItemDataSource_expressionAttributeNames
--- PASS: TestAccDynamoDBTableItem_basic (46.75s)
=== CONT TestAccDynamoDBTableItemDataSource_projectionExpression
--- PASS: TestAccDynamoDBTableItem_rangeKey (48.80s)
=== CONT TestAccDynamoDBTableItem_updateWithRangeKey
--- PASS: TestAccDynamoDBTableItemDataSource_expressionAttributeNames (53.82s)
=== CONT TestAccDynamoDBTableItem_mapOutOfBandUpdate
--- PASS: TestAccDynamoDBTableItemDataSource_projectionExpression (43.11s)
=== CONT TestAccDynamoDBTableItem_disappears
--- PASS: TestAccDynamoDBTableItem_updateWithRangeKey (56.29s)
=== CONT TestAccDynamoDBTableItem_update
--- PASS: TestAccDynamoDBTableItem_mapOutOfBandUpdate (42.33s)
=== CONT TestAccDynamoDBTableItem_wonkyItems
--- PASS: TestAccDynamoDBTableItem_disappears (36.42s)
--- PASS: TestAccDynamoDBTableItem_update (39.65s)
--- PASS: TestAccDynamoDBTableItem_wonkyItems (24.60s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb 213.278s
This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
When using a List (
"L"
) or Map ("M"
) attribute in a DynamoDB Table Item, a plan was showing a diff, like the following:The unchanged values, an
"N"
in this case, are indicated by# (1 unchanged element hidden)
.Relations
Closes #30689
References
Output from Acceptance Testing