-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Datasource aws_quicksight_data_set #30422
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎸
$ make testacc PKG=quicksight TESTS=TestAccQuickSightDataSetDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDataSetDataSource_' -timeout 180m
=== RUN TestAccQuickSightDataSetDataSource_basic
=== PAUSE TestAccQuickSightDataSetDataSource_basic
=== CONT TestAccQuickSightDataSetDataSource_basic
--- PASS: TestAccQuickSightDataSetDataSource_basic (30.80s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 33.897s
Thanks for your contribution, @comtef! 👍 |
This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Implementation of data source aws_quicksight_data_set. This is a step to quicksight resource deployment between AWS accounts. It will help to copy a dataset from a source account to a target account.
Fixed an issue on resource (logicalTableMap -> data_transforms -> project_operation) : attribute name was incorrect and type conversion needed. Found by using the data source on existing data set.
I tried to share common code between resource and data source. Should we share more?
Relations
Relates #10990
References
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeDataSet.html
Output from Acceptance Testing