Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_rds_cluster: Fix crash when attempting to update master_password #30379

Merged
merged 10 commits into from
Mar 31, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Mar 31, 2023

Description

Relations

Closes #30372.
Closes #30383.
Relates #28848.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRDSInstance_password\|TestAccRDSInstance_basic' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSInstance_password\|TestAccRDSInstance_basic -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_password
=== PAUSE TestAccRDSInstance_password
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_password
--- PASS: TestAccRDSInstance_basic (533.28s)
--- PASS: TestAccRDSInstance_password (693.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	700.100s
% make testacc TESTARGS='-run=TestAccRDSCluster_password\|TestAccRDSCluster_basic' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSCluster_password\|TestAccRDSCluster_basic -timeout 180m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_password
=== PAUSE TestAccRDSCluster_password
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_password
=== CONT  TestAccRDSCluster_basic
    cluster_test.go:43: Step 1/2 error: Check failed: 3 errors occurred:
        	* Check 13/16 error: aws_rds_cluster.test: Attribute 'reader_endpoint' expected to be set
        	* Check 14/16 error: aws_rds_cluster.test: Attribute 'scaling_configuration.#' expected "0", got "1"
        	* Check 15/16 error: aws_rds_cluster.test: Attribute 'storage_encrypted' expected "false", got "true"
        
--- PASS: TestAccRDSCluster_password (189.34s)
--- FAIL: TestAccRDSCluster_basic (315.91s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	321.166s
FAIL
make: *** [testacc] Error 1

Failure is related to #30355.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels Mar 31, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Mar 31, 2023
…word value is required when MasterUserSecretKmsKeyId is specified.'.
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 31, 2023
@ewbankkit ewbankkit merged commit bf3279d into main Mar 31, 2023
@ewbankkit ewbankkit deleted the b-aws_rds_cluster-crash branch March 31, 2023 20:55
@github-actions github-actions bot added this to the v4.62.0 milestone Mar 31, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants