Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new data source: iam_access_keys #29278

Merged
merged 6 commits into from
Apr 19, 2023

Conversation

tmatilai
Copy link
Contributor

@tmatilai tmatilai commented Feb 7, 2023

Description

The aws_iam_access_keys data source can be used to fetch information about IAM access keys of a specific IAM user.

One use case would be to conditionally create access keys (with the aws_iam_access_key resource) for a user only if none exist yet, and pass the created keys to a service which will then rotate them. This way there are no active keys in the Terraform state, nor anywhere outside the service.

Relations

Closes #25585

Output from Acceptance Testing

$ make testacc TESTS=TestAccIAMAccessKeysDataSource PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMAccessKeysDataSource'  -timeout 180m
=== RUN   TestAccIAMAccessKeysDataSource_basic
=== PAUSE TestAccIAMAccessKeysDataSource_basic
=== RUN   TestAccIAMAccessKeysDataSource_twoKeys
=== PAUSE TestAccIAMAccessKeysDataSource_twoKeys
=== CONT  TestAccIAMAccessKeysDataSource_basic
=== CONT  TestAccIAMAccessKeysDataSource_twoKeys
--- PASS: TestAccIAMAccessKeysDataSource_basic (22.36s)
--- PASS: TestAccIAMAccessKeysDataSource_twoKeys (22.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        24.459s

This data source can be used to fetch information about IAM access keys
of a specific IAM user.
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 7, 2023
@tmatilai tmatilai changed the title Add new data source: iam_access_keys Add new data source: iam_access_keys Feb 7, 2023
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 9, 2023
@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Mar 1, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIAMAccessKeysDataSource_' PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20  -run=TestAccIAMAccessKeysDataSource_ -timeout 180m
=== RUN   TestAccIAMAccessKeysDataSource_basic
=== PAUSE TestAccIAMAccessKeysDataSource_basic
=== RUN   TestAccIAMAccessKeysDataSource_twoKeys
=== PAUSE TestAccIAMAccessKeysDataSource_twoKeys
=== CONT  TestAccIAMAccessKeysDataSource_basic
=== CONT  TestAccIAMAccessKeysDataSource_twoKeys
--- PASS: TestAccIAMAccessKeysDataSource_basic (19.56s)
--- PASS: TestAccIAMAccessKeysDataSource_twoKeys (19.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	26.131s

@ewbankkit
Copy link
Contributor

@tmatilai Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ab7102b into hashicorp:main Apr 19, 2023
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 19, 2023
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@tmatilai tmatilai deleted the f-aws_iam_access_keys branch April 21, 2023 07:30
@tmatilai
Copy link
Contributor Author

Thanks for merging! 🤗

Btw, the changelog item was not included in the release notes or changelog, maybe because of this failure?
Of course this is not the most significant feature. 😅

@ewbankkit
Copy link
Contributor

@tmatilai Actually the problem is there are only 2 backtick characters at the start of .changelog/29278.txt, not 3 😄.
I'll make sure that the v4.64.0 CHANGELOG section is updated.

@tmatilai
Copy link
Contributor Author

Oh my 🤦 😂

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Source for aws_iam_access_key
2 participants