Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_kms_key - additional attributes #29250

Merged
merged 10 commits into from
Apr 19, 2023

Conversation

bennylu2
Copy link
Contributor

@bennylu2 bennylu2 commented Feb 3, 2023

Description

Additional attributes to kms data source
Add cloud_hsm_cluster_id, custom_key_store_id, key_spec, pending_deletion_window_in_days, and xks_key_configuration

Relations

Closes #29201

References

https://docs.aws.amazon.com/kms/latest/APIReference/API_KeyMetadata.html

Output from Acceptance Testing

make testacc TESTS='TestAccKMSKeyDataSource_basic' PKG=kms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20 -run='TestAccKMSKeyDataSource_basic'  -timeout 180m
=== RUN   TestAccKMSKeyDataSource_basic
=== PAUSE TestAccKMSKeyDataSource_basic
=== CONT  TestAccKMSKeyDataSource_basic
--- PASS: TestAccKMSKeyDataSource_basic (18.14s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kms        31.776s

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 3, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 3, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccKMSKeyDataSource_' PKG=kms ACCTEST_PARALELLISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20  -run=TestAccKMSKeyDataSource_ -timeout 180m
=== RUN   TestAccKMSKeyDataSource_byKeyARN
=== PAUSE TestAccKMSKeyDataSource_byKeyARN
=== RUN   TestAccKMSKeyDataSource_byKeyID
=== PAUSE TestAccKMSKeyDataSource_byKeyID
=== RUN   TestAccKMSKeyDataSource_byAliasARN
=== PAUSE TestAccKMSKeyDataSource_byAliasARN
=== RUN   TestAccKMSKeyDataSource_byAliasID
=== PAUSE TestAccKMSKeyDataSource_byAliasID
=== RUN   TestAccKMSKeyDataSource_grantToken
=== PAUSE TestAccKMSKeyDataSource_grantToken
=== RUN   TestAccKMSKeyDataSource_multiRegionConfigurationByARN
=== PAUSE TestAccKMSKeyDataSource_multiRegionConfigurationByARN
=== RUN   TestAccKMSKeyDataSource_multiRegionConfigurationByID
=== PAUSE TestAccKMSKeyDataSource_multiRegionConfigurationByID
=== CONT  TestAccKMSKeyDataSource_byKeyARN
=== CONT  TestAccKMSKeyDataSource_grantToken
=== CONT  TestAccKMSKeyDataSource_byAliasID
=== CONT  TestAccKMSKeyDataSource_multiRegionConfigurationByARN
=== CONT  TestAccKMSKeyDataSource_multiRegionConfigurationByID
=== CONT  TestAccKMSKeyDataSource_byKeyID
=== CONT  TestAccKMSKeyDataSource_byAliasARN
--- PASS: TestAccKMSKeyDataSource_byKeyID (23.12s)
--- PASS: TestAccKMSKeyDataSource_byKeyARN (23.83s)
--- PASS: TestAccKMSKeyDataSource_multiRegionConfigurationByARN (24.85s)
--- PASS: TestAccKMSKeyDataSource_multiRegionConfigurationByID (25.09s)
--- PASS: TestAccKMSKeyDataSource_byAliasARN (25.44s)
--- PASS: TestAccKMSKeyDataSource_byAliasID (25.62s)
--- PASS: TestAccKMSKeyDataSource_grantToken (30.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	36.126s

@ewbankkit
Copy link
Contributor

@bennylu2 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a23d5dc into hashicorp:main Apr 19, 2023
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 19, 2023
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/kms Issues and PRs that pertain to the kms service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_kms_key data source is missing fields
2 participants