-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_kms_key - additional attributes #29250
d/aws_kms_key - additional attributes #29250
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccKMSKeyDataSource_' PKG=kms ACCTEST_PARALELLISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20 -run=TestAccKMSKeyDataSource_ -timeout 180m
=== RUN TestAccKMSKeyDataSource_byKeyARN
=== PAUSE TestAccKMSKeyDataSource_byKeyARN
=== RUN TestAccKMSKeyDataSource_byKeyID
=== PAUSE TestAccKMSKeyDataSource_byKeyID
=== RUN TestAccKMSKeyDataSource_byAliasARN
=== PAUSE TestAccKMSKeyDataSource_byAliasARN
=== RUN TestAccKMSKeyDataSource_byAliasID
=== PAUSE TestAccKMSKeyDataSource_byAliasID
=== RUN TestAccKMSKeyDataSource_grantToken
=== PAUSE TestAccKMSKeyDataSource_grantToken
=== RUN TestAccKMSKeyDataSource_multiRegionConfigurationByARN
=== PAUSE TestAccKMSKeyDataSource_multiRegionConfigurationByARN
=== RUN TestAccKMSKeyDataSource_multiRegionConfigurationByID
=== PAUSE TestAccKMSKeyDataSource_multiRegionConfigurationByID
=== CONT TestAccKMSKeyDataSource_byKeyARN
=== CONT TestAccKMSKeyDataSource_grantToken
=== CONT TestAccKMSKeyDataSource_byAliasID
=== CONT TestAccKMSKeyDataSource_multiRegionConfigurationByARN
=== CONT TestAccKMSKeyDataSource_multiRegionConfigurationByID
=== CONT TestAccKMSKeyDataSource_byKeyID
=== CONT TestAccKMSKeyDataSource_byAliasARN
--- PASS: TestAccKMSKeyDataSource_byKeyID (23.12s)
--- PASS: TestAccKMSKeyDataSource_byKeyARN (23.83s)
--- PASS: TestAccKMSKeyDataSource_multiRegionConfigurationByARN (24.85s)
--- PASS: TestAccKMSKeyDataSource_multiRegionConfigurationByID (25.09s)
--- PASS: TestAccKMSKeyDataSource_byAliasARN (25.44s)
--- PASS: TestAccKMSKeyDataSource_byAliasID (25.62s)
--- PASS: TestAccKMSKeyDataSource_grantToken (30.47s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kms 36.126s
@bennylu2 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Additional attributes to kms data source
Add
cloud_hsm_cluster_id
,custom_key_store_id
,key_spec
,pending_deletion_window_in_days
, andxks_key_configuration
Relations
Closes #29201
References
https://docs.aws.amazon.com/kms/latest/APIReference/API_KeyMetadata.html
Output from Acceptance Testing