-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_ecs_task_definition: add execution_role_arn attribute #28662
d/aws_ecs_task_definition: add execution_role_arn attribute #28662
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ei-grad 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
f3ff98c
to
51c73c3
Compare
Hi @ei-grad, thanks for your first contribution, it looks great 🚀 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Great first contribution, I would love to see more from you in the future @ei-grad 👏
make testacc TESTS=TaskDefinitionDataSource PKG=ecs (base)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TaskDefinitionDataSource' -timeout 180m
=== RUN TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== PAUSE TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== CONT TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
--- PASS: TestAccECSTaskDefinitionDataSource_ecsTaskDefinition (23.42s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 23.498s
# Conflicts: # website/docs/d/ecs_task_definition.html.markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSTaskDefinitionDataSource_' PKG=ecs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run=TestAccECSTaskDefinitionDataSource_ -timeout 180m
=== RUN TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== PAUSE TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
=== CONT TestAccECSTaskDefinitionDataSource_ecsTaskDefinition
--- PASS: TestAccECSTaskDefinitionDataSource_ecsTaskDefinition (15.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 21.752s
@ei-grad Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add
execution_role_arn
attribute for data-sourceaws_ecs_task_definition
. It was missing for some reason.Relations
No relations.
References
https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_DescribeTaskDefinition.html
Output from Acceptance Testing