Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_glue_crawler support s3 notifications on existing glue catalog target #27745

Closed
aleksanderaleksic opened this issue Nov 10, 2022 · 3 comments · Fixed by #28156
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@aleksanderaleksic
Copy link

aleksanderaleksic commented Nov 10, 2022

Description

AWS Glue crawler now supports incremental crawling on crawlers that are already configured for a target.
See the references for more info.

Affected Resource(s) and/or Data Source(s)

  • aws_glue_crawler

Potential Terraform Configuration

Not sure what the best way to configure this feature but I see two ways.

  1. By adding an s3_target and recrawl_policy (today you are only allowed to specify one target)
resource "aws_glue_crawler" "logs" {
  ...
  catalog_target {
    database_name = var.glue_database_name
    tables        = [
      aws_glue_catalog_table.catalog.name
    ]
  }
  
  s3_target {
    path = "/AWSLogs/"
    event_queue_arn = aws_sqs_queue.s3_event_notifications.arn
  }

  recrawl_policy {
    recrawl_behavior = "CRAWL_EVENT_MODE"
  }
  1. By adding event_queue_arn attribute to the recrawl_policy
resource "aws_glue_crawler" "logs" {
  ...
  catalog_target {
    database_name = var.glue_database_name
    tables        = [
      aws_glue_catalog_table.catalog.name
    ]
  }

  recrawl_policy {
    recrawl_behavior = "CRAWL_EVENT_MODE"
    event_queue_arn = aws_sqs_queue.s3_event_notifications.arn
  }

References

https://aws.amazon.com/about-aws/whats-new/2022/10/aws-glue-crawlers-incremental-amazon-s3-crawling-existing-aws-glue-data-catalog-tables/

Would you like to implement a fix?

Yes

@aleksanderaleksic aleksanderaleksic added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Nov 10, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/glue Issues and PRs that pertain to the glue service. label Nov 10, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 10, 2022
@github-actions github-actions bot added this to the v4.46.0 milestone Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants