Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lakeformation Permissions trigger Force New #26643

Merged
merged 11 commits into from
Apr 17, 2023
Merged

Lakeformation Permissions trigger Force New #26643

merged 11 commits into from
Apr 17, 2023

Conversation

Tonkonozhenko
Copy link
Contributor

@Tonkonozhenko Tonkonozhenko commented Sep 5, 2022 •
edited by ewbankkit
Loading

Closes: #26557.
Closes: #30095.
Closes: #28448.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/XS Managed by automation to categorize the size of a PR. labels Sep 5, 2022
@justinretzolk

This comment was marked as duplicate.

Sign in to view
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 6, 2022
@Tonkonozhenko
Copy link
Contributor Author

I've just rebased onto the latest main. @ewbankkit could you review the PR, please?

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Apr 17, 2023
ewbankkit
ewbankkit approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLakeFormation_serial/Permissions' PKG=lakeformation       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/Permissions -timeout 180m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/PermissionsBasic
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/disappears
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/lfTag
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicyMultiple
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/basic
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/dataLocation
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/databaseMultiple
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicy
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/database
=== RUN   TestAccLakeFormation_serial/PermissionsBasic/databaseIAMAllowed
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/basic
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/database
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/dataLocation
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/lfTag
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/lfTagPolicy
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/table
=== RUN   TestAccLakeFormation_serial/PermissionsDataSource/tableWithColumns
=== RUN   TestAccLakeFormation_serial/PermissionsTable
=== RUN   TestAccLakeFormation_serial/PermissionsTable/basic
=== RUN   TestAccLakeFormation_serial/PermissionsTable/iamAllowed
=== RUN   TestAccLakeFormation_serial/PermissionsTable/wildcardNoSelect
=== RUN   TestAccLakeFormation_serial/PermissionsTable/selectPlus
=== RUN   TestAccLakeFormation_serial/PermissionsTable/wildcardSelectOnly
=== RUN   TestAccLakeFormation_serial/PermissionsTable/wildcardSelectPlus
=== RUN   TestAccLakeFormation_serial/PermissionsTable/implicit
=== RUN   TestAccLakeFormation_serial/PermissionsTable/multipleRoles
=== RUN   TestAccLakeFormation_serial/PermissionsTable/selectOnly
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/basic
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/implicit
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardExcludedColumns
=== RUN   TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectOnly
--- PASS: TestAccLakeFormation_serial (936.97s)
    --- PASS: TestAccLakeFormation_serial/PermissionsBasic (319.30s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/disappears (86.72s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTag (23.90s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicyMultiple (25.02s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/basic (24.82s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/dataLocation (27.10s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/databaseMultiple (32.57s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicy (24.82s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/database (26.14s)
        --- PASS: TestAccLakeFormation_serial/PermissionsBasic/databaseIAMAllowed (48.21s)
    --- PASS: TestAccLakeFormation_serial/PermissionsDataSource (181.32s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/basic (24.20s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/database (25.78s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/dataLocation (37.27s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/lfTag (24.89s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/lfTagPolicy (33.17s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/table (28.49s)
        --- PASS: TestAccLakeFormation_serial/PermissionsDataSource/tableWithColumns (26.92s)
    --- PASS: TestAccLakeFormation_serial/PermissionsTable (256.72s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/basic (25.65s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/iamAllowed (46.69s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/wildcardNoSelect (24.27s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/selectPlus (25.51s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/wildcardSelectOnly (34.04s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/wildcardSelectPlus (25.23s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/implicit (24.92s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/multipleRoles (25.45s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTable/selectOnly (24.95s)
    --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns (179.63s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus (25.48s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/basic (63.43s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/implicit (35.13s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardExcludedColumns (26.90s)
        --- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectOnly (28.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	942.524s

@ewbankkit
Copy link
Contributor

@Tonkonozhenko Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 91a8384 into hashicorp:main Apr 17, 2023
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 17, 2023
@Tonkonozhenko
Copy link
Contributor Author

@ewbankkit thank you for your PR improvements and for merging it

@Tonkonozhenko Tonkonozhenko deleted the patch-3 branch April 18, 2023 09:57
@Tonkonozhenko Tonkonozhenko restored the patch-3 branch April 18, 2023 09:58
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/lakeformation Issues and PRs that pertain to the lakeformation service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.64.0
3 participants
@Tonkonozhenko @justinretzolk @ewbankkit