feat: increase max values for lf tags

[frco9]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Feature details

When using the AWS console to create a LF Tag and its values, we can only define 15 values. However when using the aws cli and the API, the maximum values allowed per call is 50. Furthermore, it's indicated in this documentation that the soft-limit for values per tag is 1000.

This PR allows user to create tag values up to this limit.

Output from acceptance testing:

$ make testacc TESTS=TestAccLakeFormation_serial/LFTags PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_serial/LFTags'  -timeout 180m
=== RUN   TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/LFTags
=== RUN   TestAccLakeFormation_serial/LFTags/basic
=== RUN   TestAccLakeFormation_serial/LFTags/many_values
=== RUN   TestAccLakeFormation_serial/LFTags/disappears
=== RUN   TestAccLakeFormation_serial/LFTags/values
=== RUN   TestAccLakeFormation_serial/ResourceLFTags
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/basic
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/database
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/databaseMultiple
=== RUN   TestAccLakeFormation_serial/ResourceLFTags/table
--- PASS: TestAccLakeFormation_serial (134.03s)
    --- PASS: TestAccLakeFormation_serial/LFTags (51.81s)
        --- PASS: TestAccLakeFormation_serial/LFTags/basic (9.82s)
        --- PASS: TestAccLakeFormation_serial/LFTags/many_values (9.46s)
        --- PASS: TestAccLakeFormation_serial/LFTags/disappears (8.06s)
        --- PASS: TestAccLakeFormation_serial/LFTags/values (24.46s)
    --- PASS: TestAccLakeFormation_serial/ResourceLFTags (82.22s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns (19.14s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/basic (8.98s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/database (17.03s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/databaseMultiple (18.12s)
        --- PASS: TestAccLakeFormation_serial/ResourceLFTags/table (18.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	135.724s

Closes #26633

[theophilechevalier]

@ewbankkit Any chance this get reviewed soon? We're also interested.

[johnsonaj]

LGTM 🚀

$ make testacc PKG=lakeformation TESTS="TestAccLakeFormation_serial/^LFTags"
                                                                                                                                    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_serial/^LFTags'  -timeout 180m
--- PASS: TestAccLakeFormation_serial (116.51s)
    --- PASS: TestAccLakeFormation_serial/LFTags (116.51s)
        --- PASS: TestAccLakeFormation_serial/LFTags/valuesOverFifty (39.31s)
        --- PASS: TestAccLakeFormation_serial/LFTags/basic (17.12s)
        --- PASS: TestAccLakeFormation_serial/LFTags/disappears (16.06s)
        --- PASS: TestAccLakeFormation_serial/LFTags/tagKeyComplex (14.50s)
        --- PASS: TestAccLakeFormation_serial/LFTags/values (29.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	119.807s

[johnsonaj]

@frco9 thanks for the contribution! 🎉

[github-actions]

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.